MajorTanya
34102027d1
Clean up some build warnings ( mihonapp/mihon#2929 )
...
* Replace deprecated rememberPlainTooltipPositionProvider
* Remove superfluous when branch
This when is marked as exhaustive.
* Replace deprecated LibrariesContainer call
AboutLibraries now wants us to produce the libraries ourselves.
* Replace deprecated ClipboardManager with Clipboard
Clipboard uses suspend functions, hence the coroutine scope addition.
* Use multi-dollar strs to simplify GraphQL queries
These have been available since Kotlin 2.1.
* Remove various redundant casts & conversions
- WebViewScreenContent: loadingState is in the LoadingState.Loading
branch, no need to cast at all
- Bangumi: username is not modified, make val
- Kavita: token is already a String
- PagerViewerAdapter: insertPageLastPage is already null-checked
- PagerViewerAdapter: use reified filterIsInstance
- ReaderViewModel: chapter IDs are already Longs
- CloudflareInterceptor: webview is smart-cast to non-null here
* Replace deprecated MenuAnchorType
Literally just a typealias for ExposedDropdownMenuAnchorType anyway.
* OptimizeNonSkippingGroups is enabled by default
* Suppress shadowing warning
This is explicitly intentional according to the KDocs.
* Migrate Context Receivers to Context Parameters
Requires changing the compiler arg, but that is part of the migration:
https://blog.jetbrains.com/kotlin/2025/04/update-on-context-parameters
Apparently, the only visible change is that names are required now.
"_" can be used for anonymous context parameters.
* Fix expression bodies with explicit return
Naming conflict resolved by aliasing.
From 2.4/2.5 onward, these will only be allowed with explicit return
types, or have to be turned into a block body. I opted for the latter
since the function is reasonably dense already.
see: https://youtrack.jetbrains.com/issue/KTLC-288
* Suppress deprecation of non-AutoMirrored icons
We use these arrows for navigation in the Upcoming screen.
I strongly doubt the AutoMirrored versions would make sense for our
use-case.
* Explicitly opt-in to new annotation default rules
affects the following annotated value-parameters:
- Preference.SliderPreference.steps (`@IntRange`)
- ReaderViewModel.State.brightnessOverlayValue (`@IntRange`)
- ReadingMode.iconRes (`@DrawableRes`)
- MigrationListScreenModel.Dialog.Progress.progress (`@FloatRange`)
see: https://youtrack.jetbrains.com/issue/KT-73255
see: https://github.com/Kotlin/KEEP/blob/change-defaulting-rule/proposals/annotation-target-in-properties.md
Warning message was the following:
This annotation is currently applied to the value parameter only, but in the future it will also be applied to field.
- To opt in to applying to both value parameter and field, add '-Xannotation-default-target=param-property' to your compiler arguments.
- To keep applying to the value parameter only, use the '@param:' annotation target.
(cherry picked from commit b543bc089a442c5e93b0fb6c83bc4037740b1eb5)
2026-02-05 22:56:31 +07:00
AntsyLich
5aa67ebf34
Bump compile and target sdk
...
(cherry picked from commit d3b7f7e55ff6609a2cddf1765205ba35c6c26b83)
2026-01-13 14:42:37 +07:00
AntsyLich
36c8f27736
Use AGP provided NDK and Build Tools version
...
(cherry picked from commit 5fe7dd9f0612412afabd7646f89ba38b230fb7e7)
2026-01-05 14:17:51 +07:00
Cuong-Tran
ed537f97f0
Bump compileSdk to 36 ( #1191 )
2025-10-06 15:00:15 +07:00
Cuong-Tran
6ac5b6b9d2
Revert "Bump targetSdk to 35"
...
This reverts commit 0c4fd329e0 .
2025-10-06 13:02:29 +07:00
AntsyLich
0c4fd329e0
Bump targetSdk to 35
...
(cherry picked from commit 4bc3b9f3b6fc87a9285ad3ca1aa8c81d8269d373)
2025-08-27 14:32:30 +07:00
AntsyLich
bc9843e637
Use current time as build time for preview builds ( mihonapp/mihon#1876 )
...
(cherry picked from commit 935f1fcf3f8e4f9da4774d932b65ae77b44cc773)
2025-03-23 23:47:27 +07:00
AntsyLich
0df53a5125
Change 'include-analytics' to 'include-telemetry' ( mihonapp/mihon#1874 )
...
(cherry picked from commit 093e8e5c5afe970d5aa2f1c237d43ac7936256b2)
2025-03-23 23:47:21 +07:00
AntsyLich
d07d353140
For release builds use last commit time as build time ( mihonapp/mihon#1873 )
...
(cherry picked from commit dae7d179662ff6d6654e7c10e57f1aeeaf579de8)
2025-03-23 23:43:06 +07:00
AntsyLich
81209fb0d6
Move firebase stuff to a standalone module ( mihonapp/mihon#1841 )
...
(cherry picked from commit 046f09c4bdf8fe8bfe5886afefa0e440376184e7)
2025-03-23 23:43:06 +07:00
rhjdvsgsgks
686a80555f
Add build tool version to android config ( mihonapp/mihon#1803 )
...
(cherry picked from commit 7566918ee749e76c701aeda7e99d81003676a51c)
2025-03-23 23:43:06 +07:00
AntsyLich
56a15d1da6
Add more editor configs and move ktlint config to it ( mihonapp/mihon#1731 )
...
(cherry picked from commit 34d1e6fa278846dd8eb6ea82c936818d4610d3c2)
2025-02-17 15:33:18 +07:00
AntsyLich
869e1626f8
Address some deprecations
...
(cherry picked from commit d53a3828b12daead9c898bea12c9a1497d07366f)
2025-01-24 00:44:22 +07:00
AntsyLich
3c0c45eb81
Address some build warnings and cleanup ( mihonapp/mihon#1412 )
...
(cherry picked from commit a1c60897916f418726107fec80ad79b2a4b8d500)
2024-11-01 10:37:52 +07:00
AntsyLich
7d8f96d856
Cleanup .gitignore files
...
(cherry picked from commit afa50029882655af8d5eea40aed7644fce4564d8)
2024-10-23 14:19:38 +07:00
AntsyLich
a92d228a1b
Refrain from running spotless on weblate files
...
Those are akin to generated files and are likely to not follow our formatting
(cherry picked from commit 32d2c2ac1bc224cbda2f09a4023d7d120ea0e954)
2024-10-23 13:08:41 +07:00
AntsyLich
80063ffba4
Bump compile sdk to 35
...
Co-authored-by: p
(cherry picked from commit 37419cdc26c2b5c4f8583fc2ba439b08fab42856)
2024-10-23 13:08:41 +07:00
AntsyLich
331110b585
Bump NDK version ( mihonapp/mihon#1203 )
...
(cherry picked from commit fbcc48fefc7ed050f6416a8684816730bcb5f8a8)
2024-09-08 02:06:43 +07:00
AntsyLich
6d4a7f02de
Rename LocalesConfigPlugin file to LocalesConfigTask
...
(cherry picked from commit 70c1a842b207d8faf0d87635674667d190669fd1)
2024-09-05 15:26:10 +07:00
AntsyLich
c79fd145a1
Use feature flags in compose compiler plugin
...
And slight cleanup
(cherry picked from commit 8f9a325895bb7b94c2ec92dd969094fc30b3b5e2)
2024-09-04 15:46:36 +07:00
AntsyLich
62507fc3cd
Add spotless (with ktlint) ( mihonapp/mihon#1136 )
...
(cherry picked from commit 5ae8095ef1ed2ae9f98486f9148e933c77a28692)
# Conflicts:
# .github/workflows/build_pull_request.yml
# .github/workflows/build_push.yml
2024-08-26 00:08:37 +07:00
AntsyLich
7aa20b60df
Generate locales_config.xml in build dir
...
(cherry picked from commit ac41bffdc97b4cfed923de6b9e8e01cccf3eb6eb)
2024-08-26 00:08:37 +07:00
AntsyLich
335f0956b4
Remove detekt ( mihonapp/mihon#1130 )
...
Annoying. More annoying in this project.
(cherry picked from commit 777ae2461e1eb277a3aa0c998ff69e4f100387a1)
2024-08-26 00:08:37 +07:00
renovate[bot]
a0971e36a9
chore(deps): update kotlin and compose compiler to v2 (major) ( #26 , #82 , mihonapp/mihon#819 )
...
* chore(deps): update kotlin and compose compiler to v2
* Update .gitignore
* Fix build
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
(cherry picked from commit 46003ec25139319079abc9fde89b3afd344a1a11)
2024-07-27 02:13:27 +07:00
renovate[bot]
a9c0c77b96
fix(deps): update moko to v0.24.1 ( #78 )
...
* fix(deps): update moko to v0.24.1
* fix(deps): update moko to v0.24.1 (mihonapp/mihon#933 )
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
(cherry picked from commit f58a05e91828a69c01d49d629e5bfa9ec7ae3ffc)
* Fix build for i18n-kmk & i18n-sy
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cuong-Tran <cuongtran.tm@gmail.com>
2024-07-07 07:40:54 +07:00
Caio Oliveira
d71ff5f05a
buildSrc: Fix strange warning in ci build ( mihonapp/mihon#952 )
...
* buildSrc: Fix strange warning
´Project accessors enabled, but root project name not explicitly set for 'buildSrc'. Checking out the project in different folders will impact the generated code and implicitly the buildscript classpath, breaking caching.´
* Update settings.gradle.kts
---------
Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
(cherry picked from commit 2674b849746f20c051dab3fd6edfad1594e41b42)
2024-07-05 14:47:31 +07:00
AntsyLich
cdac438f1e
Make the app Android 8+
...
(cherry picked from commit dfb3091e380dda3e9bfb64bf5c9a685cf3a03d0e)
# Conflicts:
# README.md
# app/src/debug/res/mipmap-hdpi/ic_launcher.png
# app/src/debug/res/mipmap-hdpi/ic_launcher_round.png
# app/src/debug/res/mipmap-mdpi/ic_launcher.png
# app/src/debug/res/mipmap-mdpi/ic_launcher_round.png
# app/src/debug/res/mipmap-xhdpi/ic_launcher.png
# app/src/debug/res/mipmap-xhdpi/ic_launcher_round.png
# app/src/debug/res/mipmap-xxhdpi/ic_launcher.png
# app/src/debug/res/mipmap-xxhdpi/ic_launcher_round.png
# app/src/debug/res/mipmap-xxxhdpi/ic_launcher.png
# app/src/debug/res/mipmap-xxxhdpi/ic_launcher_round.png
# app/src/main/java/eu/kanade/domain/ui/UiPreferences.kt
# app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsAdvancedScreen.kt
# app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt
# app/src/main/java/eu/kanade/tachiyomi/data/coil/TachiyomiImageDecoder.kt
# app/src/main/java/eu/kanade/tachiyomi/extension/installer/ShizukuInstaller.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ZipPageLoader.kt
# app/src/main/res/mipmap-hdpi/ic_launcher.png
# app/src/main/res/mipmap-hdpi/ic_launcher_round.png
# app/src/main/res/mipmap-mdpi/ic_launcher.png
# app/src/main/res/mipmap-mdpi/ic_launcher_round.png
# app/src/main/res/mipmap-xhdpi/ic_launcher.png
# app/src/main/res/mipmap-xhdpi/ic_launcher_round.png
# app/src/main/res/mipmap-xxhdpi/ic_launcher.png
# app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png
# app/src/main/res/mipmap-xxxhdpi/ic_launcher.png
# app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png
# buildSrc/src/main/kotlin/AndroidConfig.kt
2024-06-11 00:04:02 +07:00
AntsyLich
72634e76f8
Rework buildSrc and remove usage of subprojects
...
(cherry picked from commit e448e40406e8d9916120a278e42829a6f1b25a7a)
# Conflicts:
# app/build.gradle.kts
# buildSrc/src/main/kotlin/AndroidConfig.kt
# i18n/build.gradle.kts
# source-api/build.gradle.kts
2024-04-26 11:35:15 +07:00
AntsyLich
b07a1428a3
Fix build time zone in about screen
...
And slight cleanup
(cherry picked from commit aed53d3bdc85ce0e899fbb90b9f9cad0f1b86480)
2024-04-26 11:35:15 +07:00
Cuong M. Tran
21ce8100ca
Update detekt's baseline & run detekt for future build ( #1106 )
...
* Update detekt baseline from mihon
* Update detekt baseline to current code & enable gradle's detekt task for future build
# Conflicts:
# .github/workflows/build_push.yml
# config/detekt/baseline.xml
2024-03-29 12:10:09 +07:00
Theodoro Loureiro mota
392cfda1c7
Adding Detekt in the project ( #216 )
...
* Removing ktlint
* Removing compose lint
* Adding initial Detekt config
* Setting up detekt config
* Adding detekt baseline
* Fixing workflows
* Moving to a module based solution
* Adding new line
* Adding new line
* Updating baseline
* Addressing PR suggestions
* Regenerating baseline.xml
* Cleanup
---------
Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
(cherry picked from commit cc09230e266c3cd7ed748affe92922d775523695)
# Conflicts:
# .github/workflows/build_pull_request.yml
# .github/workflows/build_push.yml
2024-02-19 17:54:43 +07:00
arkon
35e55b1517
Bump to latest NDK LTS
...
(cherry picked from commit c62cd6e997cb426ce8875a5f43ebeaa183bca7a5)
2023-12-24 14:05:38 -05:00
arkon
52f52f257e
Bump NDK
...
Just using the same version as J2K for now, we can probably go higher though.
(cherry picked from commit f20980b4c9c455703c80b120a39063e1e9a3df0a)
2023-12-24 14:05:21 -05:00
Ivan Iskandar
821a48e4d1
Target Android 14 (SDK 34) and add permission onboarding step
...
(cherry picked from commit 9e0068715f3ba3d1627c4b7539b90fb782f8122f)
(cherry picked from commit 13b3bec8ad2a5b883cbe5ec99da531fbaba7f50b)
2023-12-24 14:03:44 -05:00
arkon
0dfe2f84f3
Target Android 12L (SDK 32)
...
(cherry picked from commit c00f05a1c1f8bce83df7a9b216d2c3026c16b147)
2023-12-24 14:03:24 -05:00
arkon
865ec2e47b
Target SDK 30
...
Need to convert some services into WorkManager jobs before going to 31 and higher.
(cherry picked from commit e22eebfd02e28eb260273d987d60c216aa4a2100)
2023-12-24 11:47:09 -05:00
arkon
1eccf9fad8
Migrate to multiplatform string resources ( #10147 )
...
* Migrate to multiplatform string resources
* Move plurals translations into separate files
* Fix lint check on generated files
(cherry picked from commit 46e734fc8eefb8c06a880194e702559ca3fa769d)
# Conflicts:
# app/src/main/java/eu/kanade/presentation/browse/BrowseSourceScreen.kt
# app/src/main/java/eu/kanade/presentation/browse/ExtensionDetailsScreen.kt
# app/src/main/java/eu/kanade/presentation/browse/ExtensionsScreen.kt
# app/src/main/java/eu/kanade/presentation/browse/SourcesScreen.kt
# app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt
# app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceToolbar.kt
# app/src/main/java/eu/kanade/presentation/category/components/CategoryDialogs.kt
# app/src/main/java/eu/kanade/presentation/library/LibrarySettingsDialog.kt
# app/src/main/java/eu/kanade/presentation/manga/components/MangaBottomActionMenu.kt
# app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt
# app/src/main/java/eu/kanade/presentation/more/MoreScreen.kt
# app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsAdvancedScreen.kt
# app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsBrowseScreen.kt
# app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsLibraryScreen.kt
# app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsMainScreen.kt
# app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt
# app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsSecurityScreen.kt
# app/src/main/java/eu/kanade/presentation/more/settings/screen/about/AboutScreen.kt
# app/src/main/java/eu/kanade/presentation/more/settings/screen/advanced/ClearDatabaseScreen.kt
# app/src/main/java/eu/kanade/presentation/more/settings/screen/data/CreateBackupScreen.kt
# app/src/main/java/eu/kanade/presentation/reader/ReaderPageActionsDialog.kt
# app/src/main/java/eu/kanade/presentation/reader/appbars/BottomReaderBar.kt
# app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderAppBars.kt
# app/src/main/java/eu/kanade/presentation/reader/components/ChapterNavigator.kt
# app/src/main/java/eu/kanade/presentation/reader/settings/GeneralSettingsPage.kt
# app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadManager.kt
# app/src/main/java/eu/kanade/tachiyomi/data/download/Downloader.kt
# app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt
# app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateNotifier.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/browse/BrowseTab.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/MigrationFlags.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateDialog.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/SourceSearchScreen.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/sources/MigrateSourceTab.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/SourcesTab.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/SourceFilterDialog.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryTab.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ChapterLoader.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/reader/setting/ReaderPreferences.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/stats/StatsScreen.kt
# app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesTab.kt
# build.gradle.kts
# i18n/build.gradle.kts
# i18n/src/commonMain/resources/MR/base/strings_sy.xml
# i18n/src/commonMain/resources/MR/fr/strings_sy.xml
# i18n/src/commonMain/resources/MR/in/strings_sy.xml
# i18n/src/commonMain/resources/MR/pt-rBR/strings_sy.xml
# i18n/src/commonMain/resources/MR/ru/strings_sy.xml
# i18n/src/commonMain/resources/MR/zh-rCN/strings_sy.xml
# i18n/src/commonMain/resources/MR/zh-rTW/strings_sy.xml
2023-12-23 20:28:29 -05:00
arkon
d8158af43a
Switch to different ktlint plugin
...
Should be better at incremental builds.
To format, run `./gradlew ktlintFormat`.
(cherry picked from commit d29b7c4e5735dc137d578d3bcb3da1f0a02573e8)
# Conflicts:
# buildSrc/src/main/kotlin/tachiyomi.lint.gradle.kts
# data/src/main/java/tachiyomi/data/manga/MangaMapper.kt
# domain/src/main/java/tachiyomi/domain/library/model/LibrarySortMode.kt
# domain/src/main/java/tachiyomi/domain/library/service/LibraryPreferences.kt
# domain/src/main/java/tachiyomi/domain/release/interactor/GetApplicationRelease.kt
# presentation-core/src/main/java/tachiyomi/presentation/core/components/CollapsibleBox.kt
2023-09-04 12:15:09 -04:00
Ivan Iskandar
13f49234dc
Bump compile SDK version 34 ( #9625 )
...
(cherry picked from commit 740e370465444beaa52af7aae9016c9cf67cd066)
2023-06-24 14:17:56 -04:00
arkon
e3a5860c1a
Fix Spanish (Latin America) being missing from in-app language selection
...
(cherry picked from commit 290efb0283145d81290972991047064c1d905c9c)
2023-04-09 18:15:03 -04:00
Jobobby04
a9edf090c4
Lint
2023-02-07 16:50:09 -05:00
Andreas
34b60a435e
Create plugin for linting ( #8942 )
...
(cherry picked from commit c31e75f02f3021c52f6c24f655e2bded0c8b2b33)
# Conflicts:
# .github/workflows/build_pull_request.yml
# .github/workflows/build_push.yml
# app/build.gradle.kts
# build.gradle.kts
2023-02-07 16:11:25 -05:00
arkon
dbcc744e1f
Fix choosing regionalized locales
...
(cherry picked from commit 32190b6cacee819036245b2a39d1068a0b0c10ac)
2022-08-29 18:13:28 -04:00
Andreas
5baddd8a74
Add task to generate locales_config.xml ( #7754 )
...
(cherry picked from commit 4291cc8eb1f4385528afcc9cab2592c8b3afa44a)
# Conflicts:
# .gitignore
2022-08-14 16:05:27 -04:00
arkon
d3e8ae54d9
Bump to compile SDK 33
...
Fixes #7390 , at least according to ivaniskandar
(cherry picked from commit b15073fd6124747c1e64cffc5e758c94cf6a6b7a)
2022-07-11 11:09:09 -04:00
arkon
cd9b9642fb
Bump dependencies
...
(cherry picked from commit e3f8aedd5a4c22ded32b7f50e6a3a1b5c68011ae)
2022-06-04 20:43:16 -04:00
Andreas
1df1a331dd
Use Version Catalog & clean up Gradle files ( #6728 )
...
(cherry picked from commit f312936629657b1160723e044e14d5d0b5d8644f)
# Conflicts:
# app/build.gradle.kts
# build.gradle.kts
# settings.gradle.kts
2022-03-04 16:33:42 -05:00
arkon
3ca70543d1
Update AGP for Android Studio Bumblebee | 2021.1.1 Patch 1
...
(cherry picked from commit 30061ada58533dfdfe6509025a9bc9202259d4d5)
2022-02-12 11:55:57 -05:00
arkon
255a09abf5
Update versions plugin
...
(cherry picked from commit 7659a997cfccdcecfbb1d5a3e769a4c35a73d61a)
2022-02-12 11:41:13 -05:00
arkon
9938beb040
Update to AGP 7.1.0
...
(cherry picked from commit 18ef5c6ff9c4ef8eb1a83a7f3955e451a8862803)
2022-01-29 20:06:54 -05:00