From d19c37596bf45c41e3d33c73ca48ababaed8d56b Mon Sep 17 00:00:00 2001 From: AntsyLich <59261191+AntsyLich@users.noreply.github.com> Date: Thu, 3 Apr 2025 18:45:16 +0600 Subject: [PATCH] Fix unintended app permissions due to Firebase misconfiguration (mihonapp/mihon#1960) (cherry picked from commit 2259164fde4135cdd2d756fbec2d671d475ebb37) --- CHANGELOG.md | 1 + telemetry/build.gradle.kts | 9 ++++++--- telemetry/src/{firebase => main}/AndroidManifest.xml | 0 3 files changed, 7 insertions(+), 3 deletions(-) rename telemetry/src/{firebase => main}/AndroidManifest.xml (100%) diff --git a/CHANGELOG.md b/CHANGELOG.md index 18b91f5c3..1c471aa16 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ The format is a modified version of [Keep a Changelog](https://keepachangelog.co - Fix backup sharing from notifications not working when app is in background ([@JaymanR](https://github.com/JaymanR))([#1929](https://github.com/mihonapp/mihon/pull/1929)) - Fix mark existing duplicate read chapters as read option not working in some cases ([@AntsyLich](https://github.com/AntsyLich)) ([#1944](https://github.com/mihonapp/mihon/pull/1944)) - Fix app bar action tooltips blocking clicks ([@Bartuzen](https://github.com/Bartuzen)) ([#1928](https://github.com/mihonapp/mihon/pull/1928)) +- Fix unintended app permissions due to Firebase misconfiguration ([@AntsyLich](https://github.com/AntsyLich)) ([#1960](https://github.com/mihonapp/mihon/pull/1960)) ## [v0.18.0] - 2025-03-20 ### Added diff --git a/telemetry/build.gradle.kts b/telemetry/build.gradle.kts index 2e039c063..6ef51d8c6 100644 --- a/telemetry/build.gradle.kts +++ b/telemetry/build.gradle.kts @@ -10,9 +10,12 @@ android { sourceSets { getByName("main") { - val dir = if (Config.includeTelemetry) "firebase" else "noop" - kotlin.srcDirs("src/$dir/kotlin") - manifest.srcFile("src/$dir/AndroidManifext.xml") + if (Config.includeTelemetry) { + kotlin.srcDirs("src/firebase/kotlin") + } else { + kotlin.srcDirs("src/noop/kotlin") + manifest.srcFile("src/noop/AndroidManifext.xml") + } } } } diff --git a/telemetry/src/firebase/AndroidManifest.xml b/telemetry/src/main/AndroidManifest.xml similarity index 100% rename from telemetry/src/firebase/AndroidManifest.xml rename to telemetry/src/main/AndroidManifest.xml