From 6562ab00180a4c7a79fa389ef9964eccebeec47b Mon Sep 17 00:00:00 2001 From: AntsyLich <59261191+AntsyLich@users.noreply.github.com> Date: Mon, 5 May 2025 01:36:37 +0600 Subject: [PATCH] Add autofill support to tracker login dialog and update processing text (mihonapp/mihon#2069) (cherry picked from commit 7deeabe844d41d2b5e918ad747ddd548163c9fe3) --- CHANGELOG.md | 2 ++ .../more/settings/screen/SettingsTrackingScreen.kt | 13 ++++++++++--- i18n/src/commonMain/moko-resources/base/strings.xml | 1 + 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5db56d8fa..8e65a3ded 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,12 +27,14 @@ The format is a modified version of [Keep a Changelog](https://keepachangelog.co - Update non-library manga data when browsing ([@AntsyLich](https://github.com/AntsyLich)) ([#1967](https://github.com/mihonapp/mihon/pull/1967)) - Surface image loading error in Reader ([@AwkwardPeak7](https://github.com/AwkwardPeak7)) ([#1981](https://github.com/mihonapp/mihon/pull/1981)) - Include source headers when opening failed images from reader ([@AwkwardPeak7](https://github.com/AwkwardPeak7)) ([#2004](https://github.com/mihonapp/mihon/pull/2004)) +- Added autofill support to tracker login dialog ([@AntsyLich](https://github.com/AntsyLich)) ([#2069](https://github.com/mihonapp/mihon/pull/2069)) ### Changed - Display all similarly named duplicates in duplicate manga dialogue ([@NarwhalHorns](https://github.com/NarwhalHorns), [@AntsyLich](https://github.com/AntsyLich)) ([#1861](https://github.com/mihonapp/mihon/pull/1861)) - Display chapter count on items in duplicate manga dialogue ([@NarwhalHorns](https://github.com/NarwhalHorns)) ([#1963](https://github.com/mihonapp/mihon/pull/1963)) - Update Facebook and Reddit icons ([@Joehuu](https://github.com/Joehuu)) ([#1994](https://github.com/mihonapp/mihon/pull/1994)) - Switch default user agent to Android Chrome ([@AntsyLich](https://github.com/AntsyLich)) ([#2048](https://github.com/mihonapp/mihon/pull/2048)) +- Changed log in button text when processing tracker login ([@AntsyLich](https://github.com/AntsyLich)) ([#2069](https://github.com/mihonapp/mihon/pull/2069)) ### Fixes - Fix Bangumi search results including novels ([@MajorTanya](https://github.com/MajorTanya)) ([#1885](https://github.com/mihonapp/mihon/pull/1885)) diff --git a/app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt b/app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt index 4de5fbde8..b235d17c9 100644 --- a/app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt +++ b/app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt @@ -30,8 +30,11 @@ import androidx.compose.runtime.rememberCoroutineScope import androidx.compose.runtime.setValue import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier +import androidx.compose.ui.autofill.ContentType import androidx.compose.ui.platform.LocalContext import androidx.compose.ui.platform.LocalUriHandler +import androidx.compose.ui.semantics.contentType +import androidx.compose.ui.semantics.semantics import androidx.compose.ui.text.input.ImeAction import androidx.compose.ui.text.input.KeyboardType import androidx.compose.ui.text.input.PasswordVisualTransformation @@ -228,7 +231,9 @@ object SettingsTrackingScreen : SearchableSettings { text = { Column(verticalArrangement = Arrangement.spacedBy(12.dp)) { OutlinedTextField( - modifier = Modifier.fillMaxWidth(), + modifier = Modifier + .fillMaxWidth() + .semantics { contentType = ContentType.Username + ContentType.EmailAddress }, value = username, onValueChange = { username = it }, label = { Text(text = stringResource(uNameStringRes)) }, @@ -239,7 +244,9 @@ object SettingsTrackingScreen : SearchableSettings { var hidePassword by remember { mutableStateOf(true) } OutlinedTextField( - modifier = Modifier.fillMaxWidth(), + modifier = Modifier + .fillMaxWidth() + .semantics { contentType = ContentType.Password }, value = password, onValueChange = { password = it }, label = { Text(text = stringResource(MR.strings.password)) }, @@ -288,7 +295,7 @@ object SettingsTrackingScreen : SearchableSettings { } }, ) { - val id = if (processing) MR.strings.loading else MR.strings.login + val id = if (processing) MR.strings.logging_in else MR.strings.login Text(text = stringResource(id)) } }, diff --git a/i18n/src/commonMain/moko-resources/base/strings.xml b/i18n/src/commonMain/moko-resources/base/strings.xml index 616e4d74d..9c45dd809 100644 --- a/i18n/src/commonMain/moko-resources/base/strings.xml +++ b/i18n/src/commonMain/moko-resources/base/strings.xml @@ -660,6 +660,7 @@ Email address Password Login + Logging in… Logged in Log out from %1$s? Log out