copilot/komikku
1
0
Fork 0
Code Issues Pull requests Projects Releases 5 Packages Wiki Activity Actions

Fix some migrations never running (mihonapp/mihon#1114)

Browse source 
Both `SetupBackupCreateMigration` and `SetupLibraryUpdateMigration` were
trying to get the `App` class from Injekt which is never provided via
the `AppModule`. Using `Application` instead works since the
`workManager` property used by the respective `setupTask` functions is
an extension property on `Context`.

Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
(cherry picked from commit be124ebe86377ad77de5abd1594afd7aedf9050c)
This commit is contained in:
MajorTanya 2024-08-12 01:36:34 +02:00 committed by Cuong-Tran
parent 39f3dc970c
commit 34ef197aeb
No known key found for this signature in database
GPG key ID: 733AA7624B9315C2
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/mihon/core/migration/migrations/SetupBackupCreateMigration.kt
View file

@ -1,6 +1,6 @@
package mihon.core.migration.migrations
import eu.kanade.tachiyomi.App
import android.app.Application
import eu.kanade.tachiyomi.data.backup.create.BackupCreateJob
import mihon.core.migration.Migration
import mihon.core.migration.MigrationContext
@ -9,7 +9,7 @@ class SetupBackupCreateMigration : Migration {
override val version: Float = Migration.ALWAYS
override suspend fun invoke(migrationContext: MigrationContext): Boolean {
val context = migrationContext.get<App>() ?: return false
val context = migrationContext.get<Application>() ?: return false
BackupCreateJob.setupTask(context)
return true
}

4
app/src/main/java/mihon/core/migration/migrations/SetupLibraryUpdateMigration.kt
View file

@ -1,6 +1,6 @@
package mihon.core.migration.migrations
import eu.kanade.tachiyomi.App
import android.app.Application
import eu.kanade.tachiyomi.data.library.LibraryUpdateJob
import mihon.core.migration.Migration
import mihon.core.migration.MigrationContext
@ -9,7 +9,7 @@ class SetupLibraryUpdateMigration : Migration {
override val version: Float = Migration.ALWAYS
override suspend fun invoke(migrationContext: MigrationContext): Boolean {
val context = migrationContext.get<App>() ?: return false
val context = migrationContext.get<Application>() ?: return false
LibraryUpdateJob.setupTask(context)
return true
}