From 341cb1e4085d028acbe0160ec8e287c8c8e9e675 Mon Sep 17 00:00:00 2001 From: Cuong-Tran Date: Sun, 9 Mar 2025 16:00:14 +0700 Subject: [PATCH] Add back BUILD_TOOLS to sign-android-release workflow --- .github/workflows/build_benchmark.yml | 6 ++---- .github/workflows/build_preview.yml | 12 +++--------- .github/workflows/build_pull_request.yml | 6 ++---- .github/workflows/build_push.yml | 6 ++---- .github/workflows/build_release.yml | 10 ++-------- 5 files changed, 11 insertions(+), 29 deletions(-) diff --git a/.github/workflows/build_benchmark.yml b/.github/workflows/build_benchmark.yml index f544d5127..8d231ff4e 100644 --- a/.github/workflows/build_benchmark.yml +++ b/.github/workflows/build_benchmark.yml @@ -66,10 +66,6 @@ jobs: with: fetch-depth: 0 - - name: Setup Android SDK - run: | - ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager "build-tools;29.0.3" - - name: Set up JDK uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4.7.0 with: @@ -96,6 +92,8 @@ jobs: alias: ${{ secrets.ALIAS }} keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }} keyPassword: ${{ secrets.KEY_PASSWORD }} + env: + BUILD_TOOLS_VERSION: '35.0.1' - name: Get SHA & clean up build artifacts id: get_sha diff --git a/.github/workflows/build_preview.yml b/.github/workflows/build_preview.yml index 79348c559..d1129fe9d 100644 --- a/.github/workflows/build_preview.yml +++ b/.github/workflows/build_preview.yml @@ -121,10 +121,6 @@ jobs: with: fetch-depth: 0 - - name: Setup Android SDK - run: | - ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager "build-tools;29.0.3" - - name: Set up JDK uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4.7.0 with: @@ -174,10 +170,6 @@ jobs: with: merge-multiple: true - - name: Setup Android SDK - run: | - ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager "build-tools;29.0.3" - - name: Sign APK uses: r0adkll/sign-android-release@f30bdd30588842ac76044ecdbd4b6d0e3e813478 with: @@ -186,7 +178,9 @@ jobs: alias: ${{ secrets.ALIAS }} keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }} keyPassword: ${{ secrets.KEY_PASSWORD }} - + env: + BUILD_TOOLS_VERSION: '35.0.1' + - name: Get SHA & clean up build artifacts id: get_sha run: | diff --git a/.github/workflows/build_pull_request.yml b/.github/workflows/build_pull_request.yml index b9d8543a0..228bd13f1 100644 --- a/.github/workflows/build_pull_request.yml +++ b/.github/workflows/build_pull_request.yml @@ -40,10 +40,6 @@ jobs: - name: Dependency Review uses: actions/dependency-review-action@3b139cfc5fae8b618d3eae3675e383bb1769c019 # v4.5.0 - - name: Setup Android SDK - run: | - ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager "build-tools;29.0.3" - - name: Set up JDK uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4.7.0 with: @@ -84,6 +80,8 @@ jobs: alias: ${{ secrets.ALIAS }} keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }} keyPassword: ${{ secrets.KEY_PASSWORD }} + env: + BUILD_TOOLS_VERSION: '35.0.1' - name: Rename apk id: current_commit diff --git a/.github/workflows/build_push.yml b/.github/workflows/build_push.yml index 3725c4e78..087b379d3 100644 --- a/.github/workflows/build_push.yml +++ b/.github/workflows/build_push.yml @@ -38,10 +38,6 @@ jobs: with: fetch-depth: 0 - - name: Setup Android SDK - run: | - ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager "build-tools;29.0.3" - - name: Set up JDK uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4.7.0 with: @@ -82,6 +78,8 @@ jobs: alias: ${{ secrets.ALIAS }} keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }} keyPassword: ${{ secrets.KEY_PASSWORD }} + env: + BUILD_TOOLS_VERSION: '35.0.1' - name: Rename apk id: current_commit diff --git a/.github/workflows/build_release.yml b/.github/workflows/build_release.yml index 5f348fd2b..2ca462dca 100644 --- a/.github/workflows/build_release.yml +++ b/.github/workflows/build_release.yml @@ -94,10 +94,6 @@ jobs: with: fetch-depth: 0 - - name: Setup Android SDK - run: | - ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager "build-tools;29.0.3" - - name: Set up JDK uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4.7.0 with: @@ -153,10 +149,6 @@ jobs: with: merge-multiple: true - - name: Setup Android SDK - run: | - ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager "build-tools;29.0.3" - - name: Sign APK uses: r0adkll/sign-android-release@f30bdd30588842ac76044ecdbd4b6d0e3e813478 with: @@ -165,6 +157,8 @@ jobs: alias: ${{ secrets.ALIAS }} keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }} keyPassword: ${{ secrets.KEY_PASSWORD }} + env: + BUILD_TOOLS_VERSION: '35.0.1' - name: Get SHA & clean up build artifacts id: get_sha