copilot/komikku
1
0
Fork 0
Code Issues Pull requests Projects Releases 5 Packages Wiki Activity Actions

Add log to ScreenTransition to track screen transition by key used multiple times issue

Browse source
This commit is contained in:
Cuong-Tran 2024-06-25 12:00:09 +07:00
parent 4555ac9c89
commit 05565900db
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/src/main/java/eu/kanade/presentation/util/Navigator.kt
View file

@ -22,6 +22,8 @@ import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.cancel
import kotlinx.coroutines.plus
import logcat.LogPriority
import logcat.logcat
import soup.compose.material.motion.animation.materialSharedAxisX
import soup.compose.material.motion.animation.rememberSlideDistance
@ -41,8 +43,9 @@ interface Tab : cafe.adriel.voyager.navigator.tab.Tab {
}
abstract class Screen : Screen {
override val key: ScreenKey = uniqueScreenKey
// known bug: https://github.com/mihonapp/mihon/issues/712
// This is where it create a key Screen#uuid:transition which causes exception Key ... was used multiple times
override val key: ScreenKey = "${this::class.simpleName}#$uniqueScreenKey"
}
/**
@ -86,9 +89,10 @@ fun ScreenTransition(
targetState = navigator.lastItem,
transitionSpec = transition,
modifier = modifier,
label = "transition",
label = "screen-transition",
) { screen ->
navigator.saveableState("transition", screen) {
logcat(LogPriority.ERROR) { "ScreenTransition: ${screen.key}" }
navigator.saveableState("screen-transition", screen) {
content(screen)
}
}