From 3140f9bb55b2db75ca413e8503e44adf0a5b80b4 Mon Sep 17 00:00:00 2001 From: copilot Date: Sat, 7 Nov 2026 15:42:58 +0100 Subject: [PATCH 1/5] Prevent players from hiding Fog of War layers Clients could toggle fog visibility (and fade alpha); DisplayData synced that to everyone and defeated FoW. Block client set_visible/set_alpha, clamp host-side DisplayData updates, and ignore eye toggles for fog. Co-authored-by: Cursor --- FORK.md | 2 +- linuxinstall/install-local.sh | 0 .../Layers/DrawingProgramLayerListItem.cpp | 25 +++++++++++++++++++ .../Layers/DrawingProgramLayerManagerGUI.cpp | 7 ++++-- 4 files changed, 31 insertions(+), 3 deletions(-) mode change 100644 => 100755 linuxinstall/install-local.sh diff --git a/FORK.md b/FORK.md index efa2328..4f62652 100644 --- a/FORK.md +++ b/FORK.md @@ -33,4 +33,4 @@ Not automatic on import. Choose **Paste Image + Freistellen** from the canvas ri ## Fog of War / layer lock (host) -In the layer panel (host / local file only): mark a leaf layer as **Fog of War layer** (must sit **above** the content it covers), then paint fog with brush/shapes on that layer. Players receive a **stripped** world — only objects **fully** covered by opaque fog (not merely overlapping) are omitted from join sync and from their save. Partially covered images stay. Moving or reshaping fog (or content under it) live-updates clients: newly covered objects are unloaded, revealed ones are sent again with their resources. The host file stays complete. Fog draws at the layer’s real alpha (1.0 = fully opaque for host and players). **Lock for players** blocks client edits on a normal layer; fog layers are always locked for players (move/edit/erase rejected on the host). +In the layer panel (host / local file only): mark a leaf layer as **Fog of War layer** (must sit **above** the content it covers), then paint fog with brush/shapes on that layer. Players receive a **stripped** world — only objects **fully** covered by opaque fog (not merely overlapping) are omitted from join sync and from their save. Partially covered images stay. Moving or reshaping fog (or content under it) live-updates clients: newly covered objects are unloaded, revealed ones are sent again with their resources. The host file stays complete. Fog draws at the layer’s real alpha (1.0 = fully opaque for host and players). **Lock for players** blocks client edits on a normal layer; fog layers are always locked for players (move/edit/erase rejected on the host). Players also **cannot hide or fade** a fog layer (eye / alpha); only the host can toggle fog visibility, and the host rejects client DisplayData that would strip FoW. diff --git a/linuxinstall/install-local.sh b/linuxinstall/install-local.sh old mode 100644 new mode 100755 diff --git a/src/DrawingProgram/Layers/DrawingProgramLayerListItem.cpp b/src/DrawingProgram/Layers/DrawingProgramLayerListItem.cpp index 2937aa6..6c5d419 100644 --- a/src/DrawingProgram/Layers/DrawingProgramLayerListItem.cpp +++ b/src/DrawingProgram/Layers/DrawingProgramLayerListItem.cpp @@ -20,6 +20,7 @@ #include "DrawingProgramLayerFolder.hpp" #include #include "DrawingProgramLayer.hpp" +#include "FogStripper.hpp" #include "../../World.hpp" #include "../../MainProgram.hpp" #include "SerializedBlendMode.hpp" @@ -258,6 +259,9 @@ const std::string& DrawingProgramLayerListItem::get_name() const { } void DrawingProgramLayerListItem::set_alpha(DrawingProgramLayerManager& layerMan, float newAlpha) const { + // Players must not fade fog out — same authority as visibility. + if(is_fog_layer() && !FogStripper::world_is_host(layerMan.drawP.world)) + return; if(displayData && displayData->alpha != newAlpha) { displayData->alpha = newAlpha; layerMan.drawP.drawCache.clear_own_cached_surfaces(); @@ -270,6 +274,9 @@ float DrawingProgramLayerListItem::get_alpha() const { } void DrawingProgramLayerListItem::set_visible(DrawingProgramLayerManager& layerMan, bool newVisible) const { + // Fog of War is host-controlled; clients hiding it would sync and strip FoW for everyone. + if(is_fog_layer() && !FogStripper::world_is_host(layerMan.drawP.world)) + return; if(displayData && displayData->visible != newVisible) { displayData->visible = newVisible; layerMan.drawP.drawCache.clear_own_cached_surfaces(); @@ -393,6 +400,24 @@ void DrawingProgramLayerListItem::register_class(World& w) { } }); w.delayedUpdateObjectManager.register_class(w.netObjMan, NetworkingObjects::DelayUpdateSerializedClassManager::CustomConstructors{ + .readUpdate = [](DisplayData& o, cereal::PortableBinaryInputArchive& a, const std::shared_ptr& c) { + DisplayData incoming; + a(incoming); + // Client→host: never allow stripping fog, unlocking, hiding, or fading fog. + if(c) { + if(o.fogLayer || incoming.fogLayer) { + incoming.fogLayer = true; + incoming.playerLocked = true; + incoming.visible = true; + incoming.alpha = o.alpha; + } + else { + incoming.fogLayer = false; + incoming.playerLocked = o.playerLocked; + } + } + o = incoming; + }, .postUpdateFunc = [&](DisplayData& o) { (void)o; w.drawProg.drawCache.clear_own_cached_surfaces(); diff --git a/src/DrawingProgram/Layers/DrawingProgramLayerManagerGUI.cpp b/src/DrawingProgram/Layers/DrawingProgramLayerManagerGUI.cpp index 30f4bfd..8d44030 100644 --- a/src/DrawingProgram/Layers/DrawingProgramLayerManagerGUI.cpp +++ b/src/DrawingProgram/Layers/DrawingProgramLayerManagerGUI.cpp @@ -144,11 +144,14 @@ void DrawingProgramLayerManagerGUI::setup_list_gui() { }); } gui.set_z_index_keep_clipping_region(gui.get_z_index() + 1, [&] { + // Fog stays visible for players — eye is informational only on clients. + const bool fogVisibilityLocked = layer->is_fog_layer() && !FogStripper::world_is_host(world); svg_icon_button(gui, "visible button", layer->get_visible() ? "data/icons/eyeopen.svg" : "data/icons/eyeclose.svg", { .drawType = SelectableButton::DrawType::TRANSPARENT_ALL, .size = TreeListing::ENTRY_HEIGHT, - .onClick = [&, layer] { - layer->set_visible(layerMan, !layer->get_visible()); + .onClick = [&, layer, fogVisibilityLocked] { + if(!fogVisibilityLocked) + layer->set_visible(layerMan, !layer->get_visible()); } }); }); From 166778d451d5a3f8f1c7241a62f307ecad48dcb1 Mon Sep 17 00:00:00 2001 From: copilot Date: Sat, 7 Nov 2026 15:50:33 +0100 Subject: [PATCH 2/5] Run Windows release orchestration on Forgejo desktop-release Tower runner dispatches/waits on the private GitHub MSVC builder and verifies the public windows-continuous Forgejo release. Needs GH_BUILDER_TOKEN on the Forgejo repo. Co-authored-by: Cursor --- .forgejo/workflows/windows_release.yml | 223 ++++++++++--------------- docs/windows-runner.md | 52 +++--- 2 files changed, 111 insertions(+), 164 deletions(-) diff --git a/.forgejo/workflows/windows_release.yml b/.forgejo/workflows/windows_release.yml index 525c04d..8ab39d6 100644 --- a/.forgejo/workflows/windows_release.yml +++ b/.forgejo/workflows/windows_release.yml @@ -1,7 +1,8 @@ name: Windows Release -# Continuous Windows portable build on every push to main. -# Needs self-hosted runner label `windows-release` (MSVC 2022). +# Forgejo-orchestrated Windows portable zip. +# Tower `desktop-release` triggers the private GitHub builder (MSVC), then +# verifies the public Forgejo release tag `windows-continuous`. # See docs/windows-runner.md on: @@ -18,30 +19,18 @@ concurrency: jobs: windows-x86_64: - runs-on: windows-release - timeout-minutes: 240 + runs-on: desktop-release + timeout-minutes: 360 steps: - - name: Checkout - shell: bash - env: - FORGEJO_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - set -euo pipefail - rm -rf .git - git init . - origin_url="${GITHUB_SERVER_URL#https://}" - origin_url="${origin_url#http://}" - git remote add origin "https://oauth2:${FORGEJO_TOKEN}@${origin_url}/${GITHUB_REPOSITORY}.git" - git -c http.sslVerify=false fetch --depth=1 origin "${GITHUB_SHA}" - git checkout --force FETCH_HEAD - git submodule update --init --recursive - - - name: Resolve version + - name: Resolve expected asset id: ver shell: bash run: | set -euo pipefail - ver="$(grep -E 'CURRENT_VERSION_STRING' src/VersionConstants.hpp | head -1 | sed -E 's/.*"([^"]+)".*/\1/')" + # Shallow metadata from the triggering commit (no full Windows checkout). + ver="$(curl -fsSL -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \ + "${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/contents/src/VersionConstants.hpp?ref=${GITHUB_SHA}" \ + | python3 -c "import sys,json,base64,re; d=json.load(sys.stdin); t=base64.b64decode(d['content']).decode(); print(re.search(r'CURRENT_VERSION_STRING\s*=\s*\"([^\"]+)\"', t).group(1))")" short_sha="$(echo "${GITHUB_SHA}" | cut -c1-7)" asset_ver="${ver}+${short_sha}" zip_name="infinipaint-${asset_ver}-win-x86_64-portable.zip" @@ -50,129 +39,87 @@ jobs: echo "tag=windows-continuous" echo "asset_ver=${asset_ver}" echo "zip_name=${zip_name}" + echo "short_sha=${short_sha}" } >> "$GITHUB_OUTPUT" + echo "Expect Forgejo asset: ${zip_name}" - - name: Ensure Conan - shell: pwsh - run: | - $ErrorActionPreference = "Stop" - if (-not (Get-Command conan -ErrorAction SilentlyContinue)) { - python -m pip install --user "conan>=2,<3" - Get-ChildItem "$env:USERPROFILE\AppData\Roaming\Python" -Recurse -Filter conan.exe -ErrorAction SilentlyContinue | - ForEach-Object { $env:Path = "$($_.DirectoryName);$env:Path" } - } - conan --version - - - name: Build Windows x86_64 - shell: cmd - run: | - call windowsinstall\conan_init_x86_64.bat - if errorlevel 1 exit /b 1 - call windowsinstall\build_x86_64.bat - if errorlevel 1 exit /b 1 - - - name: Package portable zip - id: pkg - shell: pwsh - env: - ZIP_NAME: ${{ steps.ver.outputs.zip_name }} - run: | - $ErrorActionPreference = "Stop" - $exe = Get-ChildItem -Path . -Recurse -Filter infinipaint.exe | - Where-Object { $_.FullName -match 'Release' } | - Select-Object -First 1 - if (-not $exe) { throw "infinipaint.exe not found under Release" } - $outDir = Join-Path (Get-Location) "dist\portable" - Remove-Item -Recurse -Force $outDir -ErrorAction SilentlyContinue - New-Item -ItemType Directory -Force -Path $outDir | Out-Null - Copy-Item $exe.FullName (Join-Path $outDir "infinipaint.exe") - $dllDir = Join-Path (Get-Location) "windowsinstall\dlls-x86_64" - if (Test-Path $dllDir) { - Copy-Item (Join-Path $dllDir "*.dll") $outDir -ErrorAction SilentlyContinue - } - $dataSrc = Join-Path (Get-Location) "assets\data" - if (-not (Test-Path $dataSrc)) { $dataSrc = Join-Path (Get-Location) "data" } - Copy-Item -Recurse $dataSrc (Join-Path $outDir "data") - New-Item -ItemType Directory -Force -Path "dist" | Out-Null - $zipPath = Join-Path (Get-Location) "dist\$env:ZIP_NAME" - if (Test-Path $zipPath) { Remove-Item $zipPath } - Compress-Archive -Path (Join-Path $outDir "*") -DestinationPath $zipPath - "zip_path=$zipPath" | Out-File -FilePath $env:GITHUB_OUTPUT -Append -Encoding utf8 - Get-Item $zipPath | Format-List FullName, Length - - - name: Publish Forgejo release + - name: Dispatch or reuse GitHub Windows build + id: gh shell: bash env: - FORGEJO_TOKEN: ${{ secrets.GITHUB_TOKEN }} - VERSION_TAG: ${{ steps.ver.outputs.tag }} - ASSET_VER: ${{ steps.ver.outputs.asset_ver }} - VERSION: ${{ steps.ver.outputs.version }} - ZIP_NAME: ${{ steps.ver.outputs.zip_name }} - FORGEJO_CURL_INSECURE: "true" + GH_BUILDER_TOKEN: ${{ secrets.GH_BUILDER_TOKEN }} + WANT_SHA: ${{ github.sha }} run: | set -euo pipefail - zip_path="dist/${ZIP_NAME}" - test -f "$zip_path" - command -v jq >/dev/null - command -v curl >/dev/null - - curl_tls=() - if [ "${FORGEJO_CURL_INSECURE}" = "true" ]; then - curl_tls+=(--insecure) + if [ -z "${GH_BUILDER_TOKEN:-}" ]; then + echo "GH_BUILDER_TOKEN secret missing on Forgejo repo" >&2 + exit 1 fi - - api_base="${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/releases" - body=$(printf '%s\n' \ - "Continuous Windows build from \`main\`." \ - "" \ - "- Version: **${VERSION}**" \ - "- Commit: \`${GITHUB_SHA}\`" \ - "- Asset: \`${ZIP_NAME}\`" \ - "" \ - "Updated on every push to \`main\`. Requires runner label \`windows-release\` (see docs/windows-runner.md).") - - payload=$(jq -n \ - --arg tag "$VERSION_TAG" \ - --arg name "Windows continuous (${ASSET_VER})" \ - --arg body "$body" \ - '{tag_name:$tag, name:$name, body:$body, draft:false, prerelease:true}') - - tag_enc=$(jq -nr --arg t "$VERSION_TAG" '$t|@uri') - resp_file=$(mktemp) - status=$(curl "${curl_tls[@]}" -sS -o "$resp_file" -w '%{http_code}' \ - -H "Authorization: token ${FORGEJO_TOKEN}" \ - "${api_base}/tags/${tag_enc}") - - release_id="" - if [ "$status" = "200" ]; then - release_id=$(jq -r '.id' < "$resp_file") - curl "${curl_tls[@]}" -sS -X PATCH \ - -H "Authorization: token ${FORGEJO_TOKEN}" \ - -H "Content-Type: application/json" \ - -d "$payload" \ - "${api_base}/${release_id}" >/dev/null - jq -r --arg n "$ZIP_NAME" '.assets[]? | select(.name==$n) | .id' < "$resp_file" | while read -r aid; do - [ -n "$aid" ] || continue - curl "${curl_tls[@]}" -sS -X DELETE \ - -H "Authorization: token ${FORGEJO_TOKEN}" \ - "${api_base}/${release_id}/assets/${aid}" >/dev/null || true - done - elif [ "$status" = "404" ]; then - status=$(curl "${curl_tls[@]}" -sS -o "$resp_file" -w '%{http_code}' -X POST \ - -H "Authorization: token ${FORGEJO_TOKEN}" \ - -H "Content-Type: application/json" \ - -d "$payload" \ - "$api_base") - [ "$status" = "200" ] || [ "$status" = "201" ] || { cat "$resp_file"; exit 1; } - release_id=$(jq -r '.id' < "$resp_file") - else - cat "$resp_file"; exit 1 + api="https://api.github.com/repos/littlecodedragon/infinipaint" + auth=(-H "Authorization: Bearer ${GH_BUILDER_TOKEN}" -H "Accept: application/vnd.github+json") + gh_sha=$(curl -fsSL "${auth[@]}" "${api}/commits/main" | python3 -c "import sys,json; print(json.load(sys.stdin)['sha'])") + if [ "$gh_sha" != "$WANT_SHA" ]; then + echo "WARN: GitHub main=${gh_sha:0:7} != Forgejo ${WANT_SHA:0:7} — keep remotes synced (push both)." >&2 fi + runs=$(curl -fsSL "${auth[@]}" "${api}/actions/workflows/windows_release.yml/runs?branch=main&per_page=15") + run_id=$(echo "$runs" | python3 -c " + import sys, json, os + want = os.environ['WANT_SHA'] + runs = json.load(sys.stdin).get('workflow_runs', []) + # Prefer live or successful run for this SHA. + for r in runs: + if r.get('head_sha') != want: + continue + st, conc = r.get('status'), r.get('conclusion') + if st in ('queued', 'in_progress') or (st == 'completed' and conc == 'success'): + print(r['id']) + break + ") + if [ -z "${run_id}" ]; then + echo "No usable GitHub run for ${WANT_SHA:0:7} — dispatching workflow_dispatch" + code=$(curl -sS -o /tmp/gh-dispatch.json -w '%{http_code}' -X POST "${auth[@]}" \ + -H "Content-Type: application/json" \ + "${api}/actions/workflows/windows_release.yml/dispatches" \ + -d '{"ref":"main"}') + [ "$code" = "204" ] || { cat /tmp/gh-dispatch.json; exit 1; } + sleep 8 + runs=$(curl -fsSL "${auth[@]}" "${api}/actions/workflows/windows_release.yml/runs?branch=main&per_page=5") + run_id=$(echo "$runs" | python3 -c "import sys,json; print(json.load(sys.stdin)['workflow_runs'][0]['id'])") + fi + echo "run_id=${run_id}" >> "$GITHUB_OUTPUT" + echo "Tracking GitHub run ${run_id}" - name_enc=$(jq -nr --arg n "$ZIP_NAME" '$n|@uri') - curl "${curl_tls[@]}" -sS -X POST \ - -H "Authorization: token ${FORGEJO_TOKEN}" \ - -H "Content-Type: application/octet-stream" \ - --data-binary @"${zip_path}" \ - "${api_base}/${release_id}/assets?name=${name_enc}" \ - | jq -r '.browser_download_url // .name // .' + - name: Wait for GitHub build + Forgejo public release + shell: bash + env: + GH_BUILDER_TOKEN: ${{ secrets.GH_BUILDER_TOKEN }} + FORGEJO_TOKEN: ${{ secrets.GITHUB_TOKEN }} + RUN_ID: ${{ steps.gh.outputs.run_id }} + ZIP_NAME: ${{ steps.ver.outputs.zip_name }} + ASSET_VER: ${{ steps.ver.outputs.asset_ver }} + SHORT_SHA: ${{ steps.ver.outputs.short_sha }} + run: | + set -euo pipefail + api="https://api.github.com/repos/littlecodedragon/infinipaint" + auth=(-H "Authorization: Bearer ${GH_BUILDER_TOKEN}" -H "Accept: application/vnd.github+json") + fj="https://forgejo.fsociety00.cc/api/v1/repos/copilot/infinipaint/releases/tags/windows-continuous" + for i in $(seq 1 240); do + g=$(curl -fsSL "${auth[@]}" "${api}/actions/runs/${RUN_ID}") + status=$(echo "$g" | python3 -c "import sys,json;d=json.load(sys.stdin);print(d.get('status'), d.get('conclusion') or '-')") + rel=$(curl -fsSL -H "Authorization: token ${FORGEJO_TOKEN}" "$fj" || echo '{}') + rname=$(echo "$rel" | python3 -c "import sys,json;print(json.load(sys.stdin).get('name',''))" 2>/dev/null || true) + assets=$(echo "$rel" | python3 -c "import sys,json;print([a.get('name') for a in json.load(sys.stdin).get('assets',[])])" 2>/dev/null || true) + echo "$(date -u +%H:%M:%S) github=${status} forgejo=${rname} assets=${assets}" + if echo "$assets" | grep -Fq "${ZIP_NAME}" || echo "$rname" | grep -Fq "${SHORT_SHA}"; then + echo "Public Forgejo release is up to date." + exit 0 + fi + if echo "$status" | grep -q '^completed failure\|^completed cancelled\|^completed timed_out'; then + echo "GitHub Windows build failed: ${status}" >&2 + echo "$g" | python3 -c "import sys,json;print(json.load(sys.stdin).get('html_url',''))" + exit 1 + fi + sleep 60 + done + echo "Timed out waiting for Forgejo asset ${ZIP_NAME}" >&2 + exit 1 diff --git a/docs/windows-runner.md b/docs/windows-runner.md index d071a10..1b8c97f 100644 --- a/docs/windows-runner.md +++ b/docs/windows-runner.md @@ -1,10 +1,15 @@ -# Windows continuous release (GitHub Actions as private builder) +# Windows continuous release (Forgejo → private GitHub builder) Native InfiniPaint Windows builds need **MSVC** (see `docs/BUILDING.md` + `windowsinstall/`). There is no Linux cross-build path. -Policy: **Forgejo is the public fork**; GitHub is only a **private** mirror used -to run `windows-latest` CI. Friends download the zip from Forgejo — not GitHub. +Policy: + +- **Forgejo** (`copilot/infinipaint`) is the **public** fork and download site. +- **GitHub** (`littlecodedragon/infinipaint`) is a **private** builder mirror only + (`windows-latest` MSVC). Must stay private. +- Tower **`desktop-release`** runs the Forgejo workflow: it dispatches/waits on + the private GitHub build, then checks the public Forgejo release. ## Public download (friends) @@ -12,36 +17,31 @@ https://forgejo.fsociety00.cc/copilot/infinipaint/releases/tag/windows-continuou Portable zip → extract → run `infinipaint.exe`. -## Workflow +## Workflows -File: `.github/workflows/windows_release.yml` +| File | Runner | Role | +|------|--------|------| +| `.forgejo/workflows/windows_release.yml` | `desktop-release` (Tower) | Orchestrate + verify Forgejo release | +| `.github/workflows/windows_release.yml` | `windows-latest` (private) | Compile + upload Forgejo asset | -| | | -|---|---| -| Trigger | every push to `main` on the private GitHub mirror, plus `workflow_dispatch` | -| Runner | `windows-latest` (GitHub-hosted, MSVC ~195 / VS 18) | -| Build | Conan profile `win-ci` + **Ninja** (avoids CMake<4 vs `Visual Studio 18 2026`) | -| Output | public Forgejo prerelease **`windows-continuous`** (+ private GitHub copy) | +Forgejo repo secret: **`GH_BUILDER_TOKEN`** (GitHub PAT with `actions:write` / +`contents:read` on the private mirror). -Required GitHub Actions secret: `FORGEJO_TOKEN` (Forgejo PAT with release write on +GitHub Actions secret: **`FORGEJO_TOKEN`** (Forgejo PAT with release write on `copilot/infinipaint`). -Local Tower Windows can keep using `windowsinstall/conan_init_x86_64.bat` -(`conan/profiles/win-x86_64`, MSVC 194). CI generates a `win-ci` profile for -whatever MSVC `windows-latest` ships. +## Tray -## GitHub remote (private builder) +Tower CI job tray (`ci-runner-job-tray.py`) tracks: + +- `Forgejo desktop-release` — host unit (orchestrator + APK jobs) +- `Forgejo InfiniPaint Windows` — Forgejo Actions run for this workflow + +## Sync remotes ```bash -git remote add github https://github.com/littlecodedragon/infinipaint.git -git push -u github main +git push origin main # Forgejo (public) +git push github main # private builder ``` -Keep the repo **private** (Settings → Change visibility, or -`gh repo edit littlecodedragon/infinipaint --visibility private`). - -## Forgejo note - -`.forgejo/workflows/windows_release.yml` still targets a self-hosted -`windows-release` runner (optional). Primary public zips come from the GitHub -builder → Forgejo release upload above. +Keep GitHub **private**. From 8ca22f6c7c79f09a083a55152375a545b2fc8725 Mon Sep 17 00:00:00 2001 From: copilot Date: Sat, 7 Nov 2026 15:50:48 +0100 Subject: [PATCH 3/5] Document Forgejo desktop-release Windows orchestration Co-authored-by: Cursor --- FORK.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/FORK.md b/FORK.md index 4f62652..d907a46 100644 --- a/FORK.md +++ b/FORK.md @@ -10,8 +10,8 @@ Save format: `INFPNT000008` / version `0.8.0-fork` (not network-compatible with | Workflow | Trigger | Runner | Output | |----------|---------|--------|--------| -| `.github/workflows/windows_release.yml` | push `main` to private GitHub mirror | GitHub-hosted **`windows-latest`** | uploads public Forgejo tag `windows-continuous` | -| `.forgejo/workflows/windows_release.yml` | every push to `main` | Forgejo self-hosted `windows-release` (optional) | same tag on Forgejo | +| `.forgejo/workflows/windows_release.yml` | push `main` on Forgejo | Tower **`desktop-release`** | dispatches/waits private GitHub MSVC build, verifies Forgejo tag `windows-continuous` | +| `.github/workflows/windows_release.yml` | private GitHub mirror | GitHub-hosted **`windows-latest`** | compiles zip + uploads public Forgejo `windows-continuous` | **Friends (Windows):** https://forgejo.fsociety00.cc/copilot/infinipaint/releases/tag/windows-continuous — zip entpacken, `infinipaint.exe` starten. Details: [docs/windows-runner.md](docs/windows-runner.md). From 2009a3f892348ab3500e271e3978314a5e68b8c3 Mon Sep 17 00:00:00 2001 From: copilot Date: Sat, 7 Nov 2026 18:08:27 +0100 Subject: [PATCH 4/5] Fix group move drift from stale draw-cache members Group expand left sibling objects in the BVH cache, so transforms moved only the selection draw while cached surfaces stayed put. Co-authored-by: Cursor --- src/DrawingProgram/DrawingProgramSelection.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/DrawingProgram/DrawingProgramSelection.cpp b/src/DrawingProgram/DrawingProgramSelection.cpp index 00d20c6..c9a3595 100644 --- a/src/DrawingProgram/DrawingProgramSelection.cpp +++ b/src/DrawingProgram/DrawingProgramSelection.cpp @@ -364,6 +364,10 @@ void DrawingProgramSelection::expand_selection_with_groups() { for(auto* c : drawP.layerMan.get_flattened_component_list()) { if(c->obj->groupId != 0 && groupIds.contains(c->obj->groupId) && !already.contains(c) && drawP.layerMan.can_current_peer_edit_layer(c->obj->parentLayer)) { + // Same as click/lasso select: must leave the draw cache, otherwise + // transforms move the selection draw while the BVH surface stays put + // (looks like size-dependent drift between group members). + drawP.drawCache.erase_component(c); selectedSet.push_back(c); already.insert(c); } From 7f342835373310c38a4d878be286a5de7f8e936d Mon Sep 17 00:00:00 2001 From: copilot Date: Sat, 7 Nov 2026 18:12:42 +0100 Subject: [PATCH 5/5] Add host-configurable collab permissions with layered overrides. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Session/person/layer defaults plus person×layer ACL (Allow/Deny/Inherit) for draw, move, delete, hide, and layer management; bump save format to 0.9.0-fork. Co-authored-by: Cursor --- CMakeLists.txt | 1 + FORK.md | 18 ++- .../CanvasComponentAllocator.cpp | 8 +- src/ClientData.cpp | 40 +++++- src/ClientData.hpp | 9 +- src/CollabPermissions.cpp | 114 +++++++++++++++ src/CollabPermissions.hpp | 77 ++++++++++ src/DrawingProgram/DrawingProgram.cpp | 58 +++++++- src/DrawingProgram/DrawingProgram.hpp | 7 + .../Layers/DrawingProgramLayer.cpp | 5 +- .../Layers/DrawingProgramLayerListItem.cpp | 107 ++++++++++++-- .../Layers/DrawingProgramLayerListItem.hpp | 16 ++- .../Layers/DrawingProgramLayerManager.cpp | 75 +++++++++- .../Layers/DrawingProgramLayerManager.hpp | 8 ++ .../Layers/DrawingProgramLayerManagerGUI.cpp | 134 +++++++++++++----- src/Toolbar.cpp | 96 +++++++++++-- src/Toolbar.hpp | 2 + src/VersionConstants.cpp | 1 + src/VersionConstants.hpp | 6 +- src/World.cpp | 3 + 20 files changed, 715 insertions(+), 70 deletions(-) create mode 100644 src/CollabPermissions.cpp create mode 100644 src/CollabPermissions.hpp diff --git a/CMakeLists.txt b/CMakeLists.txt index 0a79194..691cd56 100755 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -36,6 +36,7 @@ set(sources "src/main.cpp" "src/DrawData.cpp" "src/FontData.cpp" "src/ClientData.cpp" + "src/CollabPermissions.cpp" "src/GridManager.cpp" "src/WorldGrid.cpp" "src/TimePoint.cpp" diff --git a/FORK.md b/FORK.md index d907a46..4e07232 100644 --- a/FORK.md +++ b/FORK.md @@ -4,7 +4,7 @@ Upstream: [ErrorAtLine0/infinipaint](https://github.com/ErrorAtLine0/infinipaint **Public forge:** https://forgejo.fsociety00.cc/copilot/infinipaint GitHub (`littlecodedragon/infinipaint`) is **private builder only** — not a public fork mirror. Source of truth stays on Forgejo. -Save format: `INFPNT000008` / version `0.8.0-fork` (not network-compatible with stock 0.6.x peers). +Save format: `INFPNT000009` / version `0.9.0-fork` (not network-compatible with stock 0.6.x peers). ## CI @@ -33,4 +33,18 @@ Not automatic on import. Choose **Paste Image + Freistellen** from the canvas ri ## Fog of War / layer lock (host) -In the layer panel (host / local file only): mark a leaf layer as **Fog of War layer** (must sit **above** the content it covers), then paint fog with brush/shapes on that layer. Players receive a **stripped** world — only objects **fully** covered by opaque fog (not merely overlapping) are omitted from join sync and from their save. Partially covered images stay. Moving or reshaping fog (or content under it) live-updates clients: newly covered objects are unloaded, revealed ones are sent again with their resources. The host file stays complete. Fog draws at the layer’s real alpha (1.0 = fully opaque for host and players). **Lock for players** blocks client edits on a normal layer; fog layers are always locked for players (move/edit/erase rejected on the host). Players also **cannot hide or fade** a fog layer (eye / alpha); only the host can toggle fog visibility, and the host rejects client DisplayData that would strip FoW. +In the layer panel (host / local file only): mark a leaf layer as **Fog of War layer** (must sit **above** the content it covers), then paint fog with brush/shapes on that layer. Players receive a **stripped** world — only objects **fully** covered by opaque fog (not merely overlapping) are omitted from join sync and from their save. Partially covered images stay. Moving or reshaping fog (or content under it) live-updates clients: newly covered objects are unloaded, revealed ones are sent again with their resources. The host file stays complete. Fog draws at the layer’s real alpha (1.0 = fully opaque for host and players). **Lock for players** is a quick toggle that sets layer-default Draw/Move/Delete to Deny; fog layers are always locked for players (move/edit/erase rejected on the host). Players also **cannot hide or fade** a fog layer (eye / alpha); only the host can toggle fog visibility, and the host rejects client DisplayData that would strip FoW. FoW visibility is still global (not per-person). + +## Collab permissions (host) + +Rights: **Draw**, **Move**, **Delete**, **Hide**, **Layers** (create/reorder/delete layers). Each right is Allow / Deny / Inherit. + +Resolution (first concrete wins): Person×Layer override → Layer defaults → Person defaults → World default (Inherit at world = Allow). + +Host UI: + +- Player list → **Session Defaults…** (world / new-player / new-layer templates) +- Player list → **Rights** per connected player (person defaults; copied from new-player template on join) +- Layer panel (host): layer defaults + per-player overrides for the selected layer + +Clients cannot escalate their own ACL; host DisplayData/ClientData updates are sanitized. diff --git a/src/CanvasComponents/CanvasComponentAllocator.cpp b/src/CanvasComponents/CanvasComponentAllocator.cpp index 059b233..89dcaac 100644 --- a/src/CanvasComponents/CanvasComponentAllocator.cpp +++ b/src/CanvasComponents/CanvasComponentAllocator.cpp @@ -45,10 +45,10 @@ void CanvasComponentAllocator::register_class(World& world) { .writeUpdate = [](const CanvasComponentAllocator& o, cereal::PortableBinaryOutputArchive& a) { a(*o.comp); }, - .readUpdate = [](CanvasComponentAllocator& o, cereal::PortableBinaryInputArchive& a, const std::shared_ptr& c) { - // Host rejects client edits of fog/locked-layer components (still consume the payload). - if(c && o.comp && o.comp->compContainer && o.comp->compContainer->parentLayer - && o.comp->compContainer->parentLayer->is_player_edit_blocked()) { + .readUpdate = [&world](CanvasComponentAllocator& o, cereal::PortableBinaryInputArchive& a, const std::shared_ptr& c) { + // Host rejects client edits without Draw on that layer (still consume the payload). + if(c && o.comp && o.comp->compContainer + && !world.drawProg.layerMan.client_may_modify_component(o.comp->compContainer, CollabRight::Draw)) { auto junk = std::unique_ptr(CanvasComponent::allocate_comp(o.comp->get_type())); a(*junk); return; diff --git a/src/ClientData.cpp b/src/ClientData.cpp index 76442e1..8c5ad4b 100644 --- a/src/ClientData.cpp +++ b/src/ClientData.cpp @@ -36,7 +36,8 @@ enum class ClientDataCommand : uint8_t { SET_WINDOW_SIZE, SET_CAM_COORDS, SEND_CHAT_MESSAGE, - SET_GRID_SIZE + SET_GRID_SIZE, + SET_PERSON_DEFAULTS }; ClientData::ClientData() { @@ -54,6 +55,7 @@ void ClientData::set_from_init_struct(const InitStruct& initStruct) { cursorColor = initStruct.cursorColor; displayName = initStruct.displayName; gridSize = initStruct.gridSize; + personDefaults = initStruct.personDefaults; } void ClientData::register_class(World& world) { @@ -92,6 +94,11 @@ void ClientData::register_class(World& world) { } break; } + case ClientDataCommand::SET_PERSON_DEFAULTS: + a(o->personDefaults); + world.drawProg.layerMan.ensure_editing_layer_is_editable(); + world.set_to_layout_gui_if_focus(); + break; } }, .writeConstructorFuncServer = default_serialize_write_func, @@ -141,6 +148,20 @@ void ClientData::register_class(World& world) { }); break; } + case ClientDataCommand::SET_PERSON_DEFAULTS: { + // Only the host may change ACLs — junk-consume client attempts. + CollabPermissionSet incoming; + a(incoming); + if(c) + break; + o->personDefaults = incoming; + o.send_server_update_to_all_clients(RELIABLE_COMMAND_CHANNEL, [](const NetObjTemporaryPtr& o, cereal::PortableBinaryOutputArchive & a) { + a(ClientDataCommand::SET_PERSON_DEFAULTS, o->personDefaults); + }); + world.drawProg.layerMan.ensure_editing_layer_is_editable(); + world.set_to_layout_gui_if_focus(); + break; + } } }, }); @@ -187,6 +208,15 @@ void ClientData::scale_up_step(const NetworkingObjects::NetObjTemporaryPtr& o, const CollabPermissionSet& defaults) { + if(o->personDefaults == defaults) + return; + o->personDefaults = defaults; + o.send_update_to_all(RELIABLE_COMMAND_CHANNEL, [](const NetObjTemporaryPtr& o, cereal::PortableBinaryOutputArchive & a) { + a(ClientDataCommand::SET_PERSON_DEFAULTS, o->personDefaults); + }); +} + void ClientData::set_display_name(const std::string& newDisplayName) { displayName = newDisplayName; } @@ -219,6 +249,14 @@ const Vector3f& ClientData::get_cursor_color() const { return cursorColor; } +const CollabPermissionSet& ClientData::get_person_defaults() const { + return personDefaults; +} + +CollabPermissionSet& ClientData::person_defaults_mut() { + return personDefaults; +} + void ClientData::draw_cursor(SkCanvas* canvas, const DrawData& drawData) const { if((drawData.cam.c.inverseScale << 10) > camCoords.inverseScale && drawData.clampDrawMinimum < camCoords.inverseScale) { canvas->save(); diff --git a/src/ClientData.hpp b/src/ClientData.hpp index 3a4f1da..01aacac 100644 --- a/src/ClientData.hpp +++ b/src/ClientData.hpp @@ -19,6 +19,7 @@ #pragma once #include #include "CoordSpaceHelper.hpp" +#include "CollabPermissions.hpp" #include #include @@ -32,6 +33,7 @@ class ClientData { Vector3f cursorColor = {1.0f, 1.0f, 1.0f}; std::string displayName; uint32_t gridSize = 0; + CollabPermissionSet personDefaults = CollabPermissionSet::all_inherit(); }; ClientData(); @@ -42,6 +44,8 @@ class ClientData { static void set_camera_coords(const NetworkingObjects::NetObjTemporaryPtr& o, const CoordSpaceHelper& newCoords); static void send_chat_message(const NetworkingObjects::NetObjTemporaryPtr& o, World& world, const std::string& chatMessage); static void scale_up_step(const NetworkingObjects::NetObjTemporaryPtr& o, World& world); + /** Host-only: push person-default ACL to all peers. */ + static void set_person_defaults(const NetworkingObjects::NetObjTemporaryPtr& o, const CollabPermissionSet& defaults); void set_display_name(const std::string& newDisplayName); void set_cursor_color(const Vector3f& newCursorColor); @@ -51,11 +55,13 @@ class ClientData { uint32_t get_grid_size() const; const std::string& get_display_name() const; const Vector3f& get_cursor_color() const; + const CollabPermissionSet& get_person_defaults() const; + CollabPermissionSet& person_defaults_mut(); void draw_cursor(SkCanvas* canvas, const DrawData& drawData) const; template void serialize(Archive& a) { - a(camCoords, windowSize, cursorPos, cursorColor, displayName, gridSize); + a(camCoords, windowSize, cursorPos, cursorColor, displayName, gridSize, personDefaults); } private: void set_from_init_struct(const InitStruct& initStruct); @@ -66,5 +72,6 @@ class ClientData { Vector3f cursorColor; std::string displayName; uint32_t gridSize; + CollabPermissionSet personDefaults; }; diff --git a/src/CollabPermissions.cpp b/src/CollabPermissions.cpp new file mode 100644 index 0000000..b2963c4 --- /dev/null +++ b/src/CollabPermissions.cpp @@ -0,0 +1,114 @@ +#include "CollabPermissions.hpp" + +CollabTriState CollabPermissionSet::get(CollabRight right) const { + switch(right) { + case CollabRight::Draw: return draw; + case CollabRight::Move: return move; + case CollabRight::Delete: return erase; + case CollabRight::Hide: return hide; + case CollabRight::ManageLayers: return manageLayers; + case CollabRight::COUNT: break; + } + return CollabTriState::Inherit; +} + +void CollabPermissionSet::set(CollabRight right, CollabTriState state) { + switch(right) { + case CollabRight::Draw: draw = state; break; + case CollabRight::Move: move = state; break; + case CollabRight::Delete: erase = state; break; + case CollabRight::Hide: hide = state; break; + case CollabRight::ManageLayers: manageLayers = state; break; + case CollabRight::COUNT: break; + } +} + +bool CollabPermissionSet::any_concrete() const { + return draw != CollabTriState::Inherit + || move != CollabTriState::Inherit + || erase != CollabTriState::Inherit + || hide != CollabTriState::Inherit + || manageLayers != CollabTriState::Inherit; +} + +CollabPermissionSet CollabPermissionSet::all_allow() { + CollabPermissionSet s; + s.draw = CollabTriState::Allow; + s.move = CollabTriState::Allow; + s.erase = CollabTriState::Allow; + s.hide = CollabTriState::Allow; + s.manageLayers = CollabTriState::Allow; + return s; +} + +CollabPermissionSet CollabPermissionSet::all_inherit() { + return CollabPermissionSet{}; +} + +CollabPermissionSet CollabPermissionSet::content_deny() { + CollabPermissionSet s; + s.draw = CollabTriState::Deny; + s.move = CollabTriState::Deny; + s.erase = CollabTriState::Deny; + return s; +} + +bool collab_resolve_allow( + CollabRight right, + const CollabPermissionSet* personLayerOverride, + const CollabPermissionSet& layerDefaults, + const CollabPermissionSet& personDefaults, + const CollabPermissionSet& worldDefault) +{ + auto pick = [&](const CollabPermissionSet& set) -> CollabTriState { + return set.get(right); + }; + if(personLayerOverride) { + CollabTriState s = pick(*personLayerOverride); + if(s != CollabTriState::Inherit) + return s == CollabTriState::Allow; + } + { + CollabTriState s = pick(layerDefaults); + if(s != CollabTriState::Inherit) + return s == CollabTriState::Allow; + } + { + CollabTriState s = pick(personDefaults); + if(s != CollabTriState::Inherit) + return s == CollabTriState::Allow; + } + CollabTriState s = pick(worldDefault); + // World Inherit → Allow (open by default). + return s != CollabTriState::Deny; +} + +const char* collab_right_label(CollabRight right) { + switch(right) { + case CollabRight::Draw: return "Draw"; + case CollabRight::Move: return "Move"; + case CollabRight::Delete: return "Delete"; + case CollabRight::Hide: return "Hide"; + case CollabRight::ManageLayers: return "Layers"; + case CollabRight::COUNT: break; + } + return "?"; +} + +const char* collab_tristate_label(CollabTriState state) { + switch(state) { + case CollabTriState::Inherit: return "Inherit"; + case CollabTriState::Allow: return "Allow"; + case CollabTriState::Deny: return "Deny"; + } + return "?"; +} + +CollabTriState collab_cycle_tristate(CollabTriState state) { + switch(state) { + case CollabTriState::Inherit: return CollabTriState::Allow; + case CollabTriState::Allow: return CollabTriState::Deny; + case CollabTriState::Deny: return CollabTriState::Inherit; + } + return CollabTriState::Inherit; +} diff --git a/src/CollabPermissions.hpp b/src/CollabPermissions.hpp new file mode 100644 index 0000000..5f5e0c5 --- /dev/null +++ b/src/CollabPermissions.hpp @@ -0,0 +1,77 @@ +/* + * InfiniPaint (fork) + * Collab ACL: World → Person → Layer → Person×Layer (Allow/Deny/Inherit) + */ +#pragma once + +#include +#include +#include +#include +#include + +enum class CollabRight : uint8_t { + Draw = 0, + Move, + Delete, + Hide, + ManageLayers, + COUNT +}; + +enum class CollabTriState : uint8_t { + Inherit = 0, + Allow = 1, + Deny = 2 +}; + +struct CollabPermissionSet { + CollabTriState draw = CollabTriState::Inherit; + CollabTriState move = CollabTriState::Inherit; + CollabTriState erase = CollabTriState::Inherit; + CollabTriState hide = CollabTriState::Inherit; + CollabTriState manageLayers = CollabTriState::Inherit; + + CollabTriState get(CollabRight right) const; + void set(CollabRight right, CollabTriState state); + bool any_concrete() const; + + static CollabPermissionSet all_allow(); + static CollabPermissionSet all_inherit(); + static CollabPermissionSet content_deny(); // Draw/Move/Delete Deny, rest Inherit + + template + void serialize(Archive& a) { + a(draw, move, erase, hide, manageLayers); + } + + bool operator==(const CollabPermissionSet&) const = default; +}; + +struct CollabSessionDefaults { + // Concrete fallback when everything inherits (Inherit treated as Allow). + CollabPermissionSet worldDefault = CollabPermissionSet::all_allow(); + // Copied onto ClientData when a player joins. + CollabPermissionSet newPlayerDefaults = CollabPermissionSet::all_inherit(); + // Copied onto new layers' DisplayData.layerDefaults. + CollabPermissionSet newLayerDefaults = CollabPermissionSet::all_inherit(); + + template + void serialize(Archive& a) { + a(worldDefault, newPlayerDefaults, newLayerDefaults); + } + + bool operator==(const CollabSessionDefaults&) const = default; +}; + +/** Resolve Allow/Deny for peer on a layer. Host callers should short-circuit before this. */ +bool collab_resolve_allow( + CollabRight right, + const CollabPermissionSet* personLayerOverride, // nullable + const CollabPermissionSet& layerDefaults, + const CollabPermissionSet& personDefaults, + const CollabPermissionSet& worldDefault); + +const char* collab_right_label(CollabRight right); +const char* collab_tristate_label(CollabTriState state); +CollabTriState collab_cycle_tristate(CollabTriState state); diff --git a/src/DrawingProgram/DrawingProgram.cpp b/src/DrawingProgram/DrawingProgram.cpp index 97fa77b..485b2fb 100644 --- a/src/DrawingProgram/DrawingProgram.cpp +++ b/src/DrawingProgram/DrawingProgram.cpp @@ -48,6 +48,8 @@ #include #include "../CanvasComponents/ImageCanvasComponent.hpp" #include "Layers/DrawingProgramLayer.hpp" +#include "../CollabPermissions.hpp" +#include #include "../ImagePreprocess.hpp" #include #include @@ -308,7 +310,44 @@ std::optional DrawingProgram::get_text_box_start return drawTool->get_text_box_start_info(); } +void DrawingProgram::register_collab_defaults_class(World& world) { + world.delayedUpdateObjectManager.register_class(world.netObjMan, NetworkingObjects::DelayUpdateSerializedClassManager::CustomConstructors{ + .readUpdate = [](CollabSessionDefaults& o, cereal::PortableBinaryInputArchive& a, const std::shared_ptr& c) { + CollabSessionDefaults incoming; + a(incoming); + // Clients cannot escalate session defaults. + if(c) + return; + o = incoming; + }, + .postUpdateFunc = [&world](CollabSessionDefaults&) { + world.drawProg.layerMan.ensure_editing_layer_is_editable(); + world.set_to_layout_gui_if_focus(); + } + }); +} + +void DrawingProgram::ensure_collab_defaults() { + if(!collabDefaults) + collabDefaults = world.netObjMan.make_obj(); +} + +const CollabSessionDefaults& DrawingProgram::collab_defaults() const { + static const CollabSessionDefaults kFallback{}; + return collabDefaults ? *collabDefaults : kFallback; +} + +void DrawingProgram::set_collab_defaults(const CollabSessionDefaults& defaults) { + ensure_collab_defaults(); + if(*collabDefaults == defaults) + return; + *collabDefaults = defaults; + world.delayedUpdateObjectManager.send_update_to_all(collabDefaults, false); + layerMan.ensure_editing_layer_is_editable(); +} + void DrawingProgram::server_init_no_file() { + ensure_collab_defaults(); layerMan.server_init_no_file(); } @@ -322,10 +361,13 @@ void DrawingProgram::scale_up(const WorldScalar& scaleUpAmount) { } void DrawingProgram::write_components_server(cereal::PortableBinaryOutputArchive& a) { + ensure_collab_defaults(); + collabDefaults.write_create_message(a); layerMan.write_components_server(a); } void DrawingProgram::read_components_client(cereal::PortableBinaryInputArchive& a) { + collabDefaults = world.netObjMan.read_create_message(a, nullptr); layerMan.read_components_client(a); drawCache.build({}); } @@ -335,6 +377,7 @@ void DrawingProgram::init_server_callbacks() { std::vector> transforms; message(transforms); + world.currentNetUpdateClient = client; auto clientData = world.netObjMan.get_obj_temporary_ref_from_id(NetworkingObjects::NetObjID(client->customID)); if(clientData->get_grid_size() < world.ownClientData->get_grid_size()) { WorldScalar scaleUpAmount = get_canvas_scale_up_amount(world.ownClientData->get_grid_size(), clientData->get_grid_size()); @@ -349,12 +392,13 @@ void DrawingProgram::init_server_callbacks() { auto objPtr = world.netObjMan.get_obj_temporary_ref_from_id(netID); if(!objPtr) continue; - if(!layerMan.client_may_modify_component(objPtr.get())) { + if(!layerMan.client_may_modify_component(objPtr.get(), CollabRight::Move)) { rejectedRestore.emplace_back(netID, objPtr->coords); continue; } allowed.emplace_back(netID, coord); } + world.currentNetUpdateClient = nullptr; if(!allowed.empty()) { process_transform_message(allowed); world.netServer->send_items_to_all_clients(RELIABLE_COMMAND_CHANNEL, CLIENT_TRANSFORM_MANY_COMPONENTS, allowed); @@ -377,15 +421,16 @@ void DrawingProgram::init_server_callbacks() { world.netServer->add_recv_callback(SERVER_SET_COMPONENT_GROUP_IDS, [&](std::shared_ptr client, cereal::PortableBinaryInputArchive& message) { std::vector> groupIds; message(groupIds); - (void)client; + world.currentNetUpdateClient = client; std::vector> allowed; allowed.reserve(groupIds.size()); for(auto& [netID, groupId] : groupIds) { auto objPtr = world.netObjMan.get_obj_temporary_ref_from_id(netID); - if(!objPtr || !layerMan.client_may_modify_component(objPtr.get())) + if(!objPtr || !layerMan.client_may_modify_component(objPtr.get(), CollabRight::Move)) continue; allowed.emplace_back(netID, groupId); } + world.currentNetUpdateClient = nullptr; if(allowed.empty()) return; process_group_id_message(allowed); @@ -466,7 +511,7 @@ void DrawingProgram::send_transforms_for(const std::vectorobj) continue; - if(!world.netObjMan.is_server() && !layerMan.client_may_modify_component(obj->obj.get())) + if(!world.netObjMan.is_server() && !layerMan.own_peer_may(CollabRight::Move, obj->obj->parentLayer)) continue; transforms.emplace_back(obj->obj.get_net_id(), obj->obj->coords); } @@ -1166,11 +1211,16 @@ void DrawingProgram::draw_drag_circle(SkCanvas* canvas, const Vector2f& sPos, co void DrawingProgram::load_file(cereal::PortableBinaryInputArchive& a, VersionNumber version) { if(version >= VersionNumber(0, 6, 0)) a(controls.lockedCameraScale); + ensure_collab_defaults(); + if(version >= VersionNumber(0, 9, 0)) + a(*collabDefaults); layerMan.load_file(a, version); } void DrawingProgram::save_file(cereal::PortableBinaryOutputArchive& a) const { a(controls.lockedCameraScale); + const_cast(this)->ensure_collab_defaults(); + a(*collabDefaults); layerMan.save_file(a); } diff --git a/src/DrawingProgram/DrawingProgram.hpp b/src/DrawingProgram/DrawingProgram.hpp index 9138a4b..4285ca7 100644 --- a/src/DrawingProgram/DrawingProgram.hpp +++ b/src/DrawingProgram/DrawingProgram.hpp @@ -37,6 +37,7 @@ #include #include "Layers/DrawingProgramLayerManager.hpp" #include "DrawingProgramSelection.hpp" +#include "../CollabPermissions.hpp" class World; class PhoneDrawingProgramScreen; @@ -71,6 +72,12 @@ class DrawingProgram { DrawingProgramCache drawCache; DrawingProgramLayerManager layerMan; + /** Host-owned session ACL defaults (world / new player / new layer). */ + NetworkingObjects::NetObjOwnerPtr collabDefaults; + void ensure_collab_defaults(); + const CollabSessionDefaults& collab_defaults() const; + void set_collab_defaults(const CollabSessionDefaults& defaults); + static void register_collab_defaults_class(World& world); Vector4f* get_foreground_color_ptr(); void switch_to_tool(DrawingProgramToolType newToolType, bool force = false); diff --git a/src/DrawingProgram/Layers/DrawingProgramLayer.cpp b/src/DrawingProgram/Layers/DrawingProgramLayer.cpp index 994de1f..7ef51c3 100644 --- a/src/DrawingProgram/Layers/DrawingProgramLayer.cpp +++ b/src/DrawingProgram/Layers/DrawingProgramLayer.cpp @@ -40,9 +40,10 @@ void DrawingProgramLayer::set_component_list_callbacks(DrawingProgramLayerListIt if(c->obj->get_comp().get_type() == CanvasComponentType::IMAGE) layerMan.drawP.updateableComponents.emplace(&(*c)); - // Live fog / lock enforcement on host + // Live ACL / fog enforcement on host if(layerMan.addToCacheOnComponentInsert && layerMan.drawP.world.netServer) { - if(layerMan.drawP.world.currentNetUpdateClient && layerListItem.is_player_edit_blocked()) { + if(layerMan.drawP.world.currentNetUpdateClient + && !layerMan.current_net_client_may(CollabRight::Draw, &layerListItem)) { layerMan.defer_reject_component(&layerListItem, c->obj.get_net_id()); return; } diff --git a/src/DrawingProgram/Layers/DrawingProgramLayerListItem.cpp b/src/DrawingProgram/Layers/DrawingProgramLayerListItem.cpp index 6c5d419..a849c61 100644 --- a/src/DrawingProgram/Layers/DrawingProgramLayerListItem.cpp +++ b/src/DrawingProgram/Layers/DrawingProgramLayerListItem.cpp @@ -19,11 +19,13 @@ #include "DrawingProgramLayerListItem.hpp" #include "DrawingProgramLayerFolder.hpp" #include +#include #include "DrawingProgramLayer.hpp" #include "FogStripper.hpp" #include "../../World.hpp" #include "../../MainProgram.hpp" #include "SerializedBlendMode.hpp" +#include "../../DrawingProgram/DrawingProgram.hpp" using namespace NetworkingObjects; @@ -179,17 +181,39 @@ DrawingProgramLayer& DrawingProgramLayerListItem::get_layer() const { return *layerData; } +void DrawingProgramLayerListItem::DisplayData::migrate_player_locked_into_defaults() { + if(playerLocked && !fogLayer) + layerDefaults = CollabPermissionSet::content_deny(); +} + +void DrawingProgramLayerListItem::DisplayData::sync_player_locked_from_defaults() { + if(fogLayer) { + playerLocked = true; + return; + } + playerLocked = layerDefaults.draw == CollabTriState::Deny + && layerDefaults.move == CollabTriState::Deny + && layerDefaults.erase == CollabTriState::Deny; +} + void DrawingProgramLayerListItem::load_file(cereal::PortableBinaryInputArchive& a, VersionNumber version, DrawingProgramLayerManager& layerMan) { nameData = layerMan.drawP.world.netObjMan.make_obj(); a(*nameData); displayData = layerMan.drawP.world.netObjMan.make_obj(); - if(version >= VersionNumber(0, 8, 0)) { + if(version >= VersionNumber(0, 9, 0)) { a(*displayData); - // Normalize cereal bools (non-0/1 bytes must not stick as "true" forever). displayData->visible = displayData->visible ? true : false; displayData->playerLocked = displayData->playerLocked ? true : false; displayData->fogLayer = displayData->fogLayer ? true : false; + displayData->sync_player_locked_from_defaults(); + } + else if(version >= VersionNumber(0, 8, 0)) { + a(displayData->alpha, displayData->visible, displayData->blendMode, displayData->playerLocked, displayData->fogLayer); + displayData->visible = displayData->visible ? true : false; + displayData->playerLocked = displayData->playerLocked ? true : false; + displayData->fogLayer = displayData->fogLayer ? true : false; + displayData->migrate_player_locked_into_defaults(); } else { a(displayData->alpha, displayData->visible, displayData->blendMode); @@ -262,6 +286,8 @@ void DrawingProgramLayerListItem::set_alpha(DrawingProgramLayerManager& layerMan // Players must not fade fog out — same authority as visibility. if(is_fog_layer() && !FogStripper::world_is_host(layerMan.drawP.world)) return; + if(!FogStripper::world_is_host(layerMan.drawP.world) && !layerMan.own_peer_may(CollabRight::Hide, this)) + return; if(displayData && displayData->alpha != newAlpha) { displayData->alpha = newAlpha; layerMan.drawP.drawCache.clear_own_cached_surfaces(); @@ -277,6 +303,8 @@ void DrawingProgramLayerListItem::set_visible(DrawingProgramLayerManager& layerM // Fog of War is host-controlled; clients hiding it would sync and strip FoW for everyone. if(is_fog_layer() && !FogStripper::world_is_host(layerMan.drawP.world)) return; + if(!FogStripper::world_is_host(layerMan.drawP.world) && !layerMan.own_peer_may(CollabRight::Hide, this)) + return; if(displayData && displayData->visible != newVisible) { displayData->visible = newVisible; layerMan.drawP.drawCache.clear_own_cached_surfaces(); @@ -304,12 +332,23 @@ void DrawingProgramLayerListItem::set_player_locked(DrawingProgramLayerManager& if(!displayData) return; bool newLocked = locked || displayData->fogLayer; - if(displayData->playerLocked != newLocked) { - displayData->playerLocked = newLocked; - layerMan.drawP.drawCache.clear_own_cached_surfaces(); - layerMan.drawP.world.delayedUpdateObjectManager.send_update_to_all(displayData, false); - layerMan.refresh_fog_client_projection(); + CollabPermissionSet nextDefaults = displayData->layerDefaults; + if(newLocked) + nextDefaults = CollabPermissionSet::content_deny(); + else if(displayData->playerLocked) { + // Unlock: clear content Deny back to Inherit for Draw/Move/Delete. + nextDefaults.draw = CollabTriState::Inherit; + nextDefaults.move = CollabTriState::Inherit; + nextDefaults.erase = CollabTriState::Inherit; } + if(displayData->playerLocked == newLocked && displayData->layerDefaults == nextDefaults) + return; + displayData->playerLocked = newLocked; + displayData->layerDefaults = nextDefaults; + layerMan.drawP.drawCache.clear_own_cached_surfaces(); + layerMan.drawP.world.delayedUpdateObjectManager.send_update_to_all(displayData, false); + layerMan.refresh_fog_client_projection(); + layerMan.ensure_editing_layer_is_editable(); } bool DrawingProgramLayerListItem::get_player_locked() const { @@ -335,6 +374,55 @@ bool DrawingProgramLayerListItem::is_player_edit_blocked() const { return is_fog_layer() || get_player_locked(); } +const CollabPermissionSet& DrawingProgramLayerListItem::get_layer_defaults() const { + static const CollabPermissionSet kInherit = CollabPermissionSet::all_inherit(); + return displayData ? displayData->layerDefaults : kInherit; +} + +void DrawingProgramLayerListItem::set_layer_defaults(DrawingProgramLayerManager& layerMan, const CollabPermissionSet& defaults) const { + if(!displayData || displayData->layerDefaults == defaults) + return; + displayData->layerDefaults = defaults; + displayData->sync_player_locked_from_defaults(); + layerMan.drawP.world.delayedUpdateObjectManager.send_update_to_all(displayData, false); + layerMan.ensure_editing_layer_is_editable(); +} + +const std::map& DrawingProgramLayerListItem::get_person_layer_overrides() const { + static const std::map kEmpty; + return displayData ? displayData->personOverrides : kEmpty; +} + +void DrawingProgramLayerListItem::set_person_layer_override(DrawingProgramLayerManager& layerMan, const std::string& displayName, const CollabPermissionSet& overrides) const { + if(!displayData || displayName.empty()) + return; + if(!overrides.any_concrete()) { + clear_person_layer_override(layerMan, displayName); + return; + } + auto it = displayData->personOverrides.find(displayName); + if(it != displayData->personOverrides.end() && it->second == overrides) + return; + displayData->personOverrides[displayName] = overrides; + layerMan.drawP.world.delayedUpdateObjectManager.send_update_to_all(displayData, false); + layerMan.ensure_editing_layer_is_editable(); +} + +void DrawingProgramLayerListItem::clear_person_layer_override(DrawingProgramLayerManager& layerMan, const std::string& displayName) const { + if(!displayData) + return; + if(displayData->personOverrides.erase(displayName) == 0) + return; + layerMan.drawP.world.delayedUpdateObjectManager.send_update_to_all(displayData, false); + layerMan.ensure_editing_layer_is_editable(); +} + +void DrawingProgramLayerListItem::apply_new_layer_permission_defaults(DrawingProgramLayerManager& layerMan) const { + if(!displayData || is_folder()) + return; + set_layer_defaults(layerMan, layerMan.drawP.collab_defaults().newLayerDefaults); +} + void DrawingProgramLayerListItem::set_metainfo(DrawingProgramLayerManager& layerMan, const DrawingProgramLayerListItemMetaInfo& metaInfo) { set_blend_mode(layerMan, metaInfo.blendMode); set_alpha(layerMan, metaInfo.alpha); @@ -403,7 +491,7 @@ void DrawingProgramLayerListItem::register_class(World& w) { .readUpdate = [](DisplayData& o, cereal::PortableBinaryInputArchive& a, const std::shared_ptr& c) { DisplayData incoming; a(incoming); - // Client→host: never allow stripping fog, unlocking, hiding, or fading fog. + // Client→host: never allow stripping fog, unlocking, hiding, fading fog, or escalating ACL. if(c) { if(o.fogLayer || incoming.fogLayer) { incoming.fogLayer = true; @@ -415,8 +503,11 @@ void DrawingProgramLayerListItem::register_class(World& w) { incoming.fogLayer = false; incoming.playerLocked = o.playerLocked; } + incoming.layerDefaults = o.layerDefaults; + incoming.personOverrides = o.personOverrides; } o = incoming; + o.sync_player_locked_from_defaults(); }, .postUpdateFunc = [&](DisplayData& o) { (void)o; diff --git a/src/DrawingProgram/Layers/DrawingProgramLayerListItem.hpp b/src/DrawingProgram/Layers/DrawingProgramLayerListItem.hpp index 9f13dab..2b99695 100644 --- a/src/DrawingProgram/Layers/DrawingProgramLayerListItem.hpp +++ b/src/DrawingProgram/Layers/DrawingProgramLayerListItem.hpp @@ -20,10 +20,12 @@ #include #include #include +#include #include #include "DrawingProgramLayerFolder.hpp" #include "DrawingProgramLayer.hpp" #include "SerializedBlendMode.hpp" +#include "../../CollabPermissions.hpp" #include "../../CanvasComponents/CanvasComponentContainer.hpp" class DrawingProgramLayerFolder; @@ -89,6 +91,14 @@ class DrawingProgramLayerListItem { // Fog layers are always treated as player-locked for edit checks. bool is_player_edit_blocked() const; + const CollabPermissionSet& get_layer_defaults() const; + void set_layer_defaults(DrawingProgramLayerManager& layerMan, const CollabPermissionSet& defaults) const; + const std::map& get_person_layer_overrides() const; + void set_person_layer_override(DrawingProgramLayerManager& layerMan, const std::string& displayName, const CollabPermissionSet& overrides) const; + void clear_person_layer_override(DrawingProgramLayerManager& layerMan, const std::string& displayName) const; + /** Apply session new-layer defaults (call after create). */ + void apply_new_layer_permission_defaults(DrawingProgramLayerManager& layerMan) const; + void set_metainfo(DrawingProgramLayerManager& layerMan, const DrawingProgramLayerListItemMetaInfo& metaInfo); DrawingProgramLayerListItemMetaInfo get_metainfo() const; @@ -115,9 +125,13 @@ class DrawingProgramLayerListItem { SerializedBlendMode blendMode = SerializedBlendMode::BLEND_SRC_OVER; bool playerLocked = false; bool fogLayer = false; + CollabPermissionSet layerDefaults = CollabPermissionSet::all_inherit(); + std::map personOverrides; template void serialize(Archive& a) { - a(alpha, visible, blendMode, playerLocked, fogLayer); + a(alpha, visible, blendMode, playerLocked, fogLayer, layerDefaults, personOverrides); } + void migrate_player_locked_into_defaults(); + void sync_player_locked_from_defaults(); }; NetworkingObjects::NetObjOwnerPtr nameData; NetworkingObjects::NetObjOwnerPtr displayData; diff --git a/src/DrawingProgram/Layers/DrawingProgramLayerManager.cpp b/src/DrawingProgram/Layers/DrawingProgramLayerManager.cpp index d1a6947..2ae95ab 100644 --- a/src/DrawingProgram/Layers/DrawingProgramLayerManager.cpp +++ b/src/DrawingProgram/Layers/DrawingProgramLayerManager.cpp @@ -19,6 +19,7 @@ #include "DrawingProgramLayerManager.hpp" #include "FogStripper.hpp" #include "../../World.hpp" +#include "../../ClientData.hpp" #include "Helpers/NetworkingObjects/NetObjID.hpp" #include "Helpers/NetworkingObjects/NetObjOrderedList.hpp" #include "Helpers/NetworkingObjects/NetObjOwnerPtr.decl.hpp" @@ -291,20 +292,88 @@ void DrawingProgramLayerManager::disable_add_to_cache_and_commit_update_block(co addToCacheOnComponentInsert = true; } -bool DrawingProgramLayerManager::can_current_peer_edit_layer(const DrawingProgramLayerListItem* layer) const { +bool DrawingProgramLayerManager::peer_may(CollabRight right, const DrawingProgramLayerListItem* layer, const ClientData* peer) const { if(!layer) return false; + if(FogStripper::world_is_host(drawP.world) && (!peer || peer == drawP.world.ownClientData.get())) + return true; + // Content rights on fog layers are always denied for non-host peers. + if(layer->is_fog_layer() + && (right == CollabRight::Draw || right == CollabRight::Move || right == CollabRight::Delete)) + return false; + if(right == CollabRight::Hide && layer->is_fog_layer()) + return false; + + CollabPermissionSet personDefaults = CollabPermissionSet::all_inherit(); + const CollabPermissionSet* personLayer = nullptr; + std::string peerName; + if(peer) { + personDefaults = peer->get_person_defaults(); + peerName = peer->get_display_name(); + auto& overrides = layer->get_person_layer_overrides(); + auto it = overrides.find(peerName); + if(it != overrides.end()) + personLayer = &it->second; + } + return collab_resolve_allow( + right, + personLayer, + layer->get_layer_defaults(), + personDefaults, + drawP.collab_defaults().worldDefault); +} + +bool DrawingProgramLayerManager::own_peer_may(CollabRight right, const DrawingProgramLayerListItem* layer) const { if(FogStripper::world_is_host(drawP.world)) return true; - return !layer->is_player_edit_blocked(); + return peer_may(right, layer, drawP.world.ownClientData.get()); +} + +bool DrawingProgramLayerManager::peer_may_manage_layers(const ClientData* peer) const { + if(FogStripper::world_is_host(drawP.world) && (!peer || peer == drawP.world.ownClientData.get())) + return true; + // ManageLayers is not layer-scoped — resolve with empty layer defaults / no person×layer. + CollabPermissionSet personDefaults = peer ? peer->get_person_defaults() : CollabPermissionSet::all_inherit(); + return collab_resolve_allow( + CollabRight::ManageLayers, + nullptr, + CollabPermissionSet::all_inherit(), + personDefaults, + drawP.collab_defaults().worldDefault); +} + +bool DrawingProgramLayerManager::current_net_client_may(CollabRight right, const DrawingProgramLayerListItem* layer) const { + if(!drawP.world.currentNetUpdateClient) + return true; // local/host-originated + auto peer = drawP.world.netObjMan.get_obj_temporary_ref_from_id( + NetworkingObjects::NetObjID(drawP.world.currentNetUpdateClient->customID)); + if(!peer) + return false; + if(right == CollabRight::ManageLayers) + return peer_may_manage_layers(peer.get()); + return peer_may(right, layer, peer.get()); +} + +bool DrawingProgramLayerManager::can_current_peer_edit_layer(const DrawingProgramLayerListItem* layer) const { + return own_peer_may(CollabRight::Draw, layer); } bool DrawingProgramLayerManager::client_may_modify_component(const CanvasComponentContainer* comp) const { + return client_may_modify_component(comp, CollabRight::Draw); +} + +bool DrawingProgramLayerManager::client_may_modify_component(const CanvasComponentContainer* comp, CollabRight right) const { // Host-side authority check for CLIENT messages — must NOT use can_current_peer_edit_layer // (that always returns true on the host). if(!comp || !comp->parentLayer) return false; - return !comp->parentLayer->is_player_edit_blocked(); + if(!drawP.world.currentNetUpdateClient) { + // Transform callbacks set currentNetUpdateClient; fallback: legacy lock/fog. + if(comp->parentLayer->is_player_edit_blocked()) + return false; + return true; + } + return current_net_client_may(right, comp->parentLayer); } void DrawingProgramLayerManager::ensure_editing_layer_is_editable() { diff --git a/src/DrawingProgram/Layers/DrawingProgramLayerManager.hpp b/src/DrawingProgram/Layers/DrawingProgramLayerManager.hpp index 6c22977..a0bcda3 100644 --- a/src/DrawingProgram/Layers/DrawingProgramLayerManager.hpp +++ b/src/DrawingProgram/Layers/DrawingProgramLayerManager.hpp @@ -19,9 +19,12 @@ #pragma once #include "DrawingProgramLayerListItem.hpp" #include "DrawingProgramLayerManagerGUI.hpp" +#include "../../CollabPermissions.hpp" #include #include +class ClientData; + class DrawingProgramLayerManager { private: DrawingProgram& drawP; @@ -89,6 +92,11 @@ class DrawingProgramLayerManager { bool can_current_peer_edit_layer(const DrawingProgramLayerListItem* layer) const; bool client_may_modify_component(const CanvasComponentContainer* comp) const; + bool client_may_modify_component(const CanvasComponentContainer* comp, CollabRight right) const; + bool own_peer_may(CollabRight right, const DrawingProgramLayerListItem* layer) const; + bool peer_may(CollabRight right, const DrawingProgramLayerListItem* layer, const ClientData* peer) const; + bool peer_may_manage_layers(const ClientData* peer) const; + bool current_net_client_may(CollabRight right, const DrawingProgramLayerListItem* layer) const; void ensure_editing_layer_is_editable(); /** Host: recompute fog coverage and erase/reveal (+ resources) on clients. */ void refresh_fog_client_projection(); diff --git a/src/DrawingProgram/Layers/DrawingProgramLayerManagerGUI.cpp b/src/DrawingProgram/Layers/DrawingProgramLayerManagerGUI.cpp index 8d44030..32a6020 100644 --- a/src/DrawingProgram/Layers/DrawingProgramLayerManagerGUI.cpp +++ b/src/DrawingProgram/Layers/DrawingProgramLayerManagerGUI.cpp @@ -26,6 +26,8 @@ #include "Helpers/ConvertVec.hpp" #include "Helpers/NetworkingObjects/NetObjOrderedList.hpp" #include "SerializedBlendMode.hpp" +#include "../../CollabPermissions.hpp" +#include "../../ClientData.hpp" #include "../../GUIStuff/ElementHelpers/TextLabelHelpers.hpp" #include "../../GUIStuff/ElementHelpers/ButtonHelpers.hpp" @@ -150,20 +152,22 @@ void DrawingProgramLayerManagerGUI::setup_list_gui() { .drawType = SelectableButton::DrawType::TRANSPARENT_ALL, .size = TreeListing::ENTRY_HEIGHT, .onClick = [&, layer, fogVisibilityLocked] { - if(!fogVisibilityLocked) + if(!fogVisibilityLocked && layerMan.own_peer_may(CollabRight::Hide, layer.get())) layer->set_visible(layerMan, !layer->get_visible()); } }); }); - gui.set_z_index_keep_clipping_region(gui.get_z_index() + 1, [&] { - svg_icon_button(gui, "delete button", "data/icons/trash.svg", { - .drawType = SelectableButton::DrawType::TRANSPARENT_ALL, - .size = TreeListing::ENTRY_HEIGHT, - .onClick = [&, objIndex] { - remove_layer(objIndex); - } + if(layerMan.peer_may_manage_layers(world.ownClientData.get())) { + gui.set_z_index_keep_clipping_region(gui.get_z_index() + 1, [&] { + svg_icon_button(gui, "delete button", "data/icons/trash.svg", { + .drawType = SelectableButton::DrawType::TRANSPARENT_ALL, + .size = TreeListing::ENTRY_HEIGHT, + .onClick = [&, objIndex] { + remove_layer(objIndex); + } + }); }); - }); + } }, .onDoubleClick = [&](const TreeListingObjIndexList& objIndex) { auto layer = get_layer_from_obj_index(objIndex); @@ -196,6 +200,8 @@ void DrawingProgramLayerManagerGUI::setup_list_gui() { } }, .moveObj = [&](const std::vector& objectIndicesTreeListing, const TreeListingObjIndexList& newObjIndexTreeListing) { + if(!layerMan.peer_may_manage_layers(world.ownClientData.get())) + return; NetObjID listObj; size_t index; struct ParentObjectIDPair { @@ -396,32 +402,34 @@ void DrawingProgramLayerManagerGUI::setup_list_gui() { }); } - left_to_right_line_layout(gui, [&]() { - input_text(gui, "input new name", &nameForNew, { - .onEnter = [&] { - auto newLayerObjInfo = create_layer(new DrawingProgramLayerListItem(world.netObjMan, nameForNew, false)); - layerMan.editingLayer = newLayerObjInfo->obj; - layerMan.drawP.world.main.g.gui.set_to_layout(); - } - }); + if(layerMan.peer_may_manage_layers(world.ownClientData.get())) { + left_to_right_line_layout(gui, [&]() { + input_text(gui, "input new name", &nameForNew, { + .onEnter = [&] { + auto newLayerObjInfo = create_layer(new DrawingProgramLayerListItem(world.netObjMan, nameForNew, false)); + layerMan.editingLayer = newLayerObjInfo->obj; + layerMan.drawP.world.main.g.gui.set_to_layout(); + } + }); - svg_icon_button(gui, "create new layer", "data/icons/plusbold.svg", { - .size = SMALL_BUTTON_SIZE, - .onClick = [&] { - auto newLayerObjInfo = create_layer(new DrawingProgramLayerListItem(world.netObjMan, nameForNew, false)); - layerMan.editingLayer = newLayerObjInfo->obj; - layerMan.drawP.world.main.g.gui.set_to_layout(); - } - }); + svg_icon_button(gui, "create new layer", "data/icons/plusbold.svg", { + .size = SMALL_BUTTON_SIZE, + .onClick = [&] { + auto newLayerObjInfo = create_layer(new DrawingProgramLayerListItem(world.netObjMan, nameForNew, false)); + layerMan.editingLayer = newLayerObjInfo->obj; + layerMan.drawP.world.main.g.gui.set_to_layout(); + } + }); - svg_icon_button(gui, "create new folder", "data/icons/folderbold.svg", { - .size = SMALL_BUTTON_SIZE, - .onClick = [&] { - auto newFolderObjInfo = create_layer(new DrawingProgramLayerListItem(world.netObjMan, nameForNew, true)); - newFolderObjInfo->obj->get_folder().isFolderOpen = true; - } + svg_icon_button(gui, "create new folder", "data/icons/folderbold.svg", { + .size = SMALL_BUTTON_SIZE, + .onClick = [&] { + auto newFolderObjInfo = create_layer(new DrawingProgramLayerListItem(world.netObjMan, nameForNew, true)); + newFolderObjInfo->obj->get_folder().isFolderOpen = true; + } + }); }); - }); + } auto editingLayerLock = editingLayer.lock(); if(editingLayerLock) { @@ -479,6 +487,67 @@ void DrawingProgramLayerManagerGUI::setup_list_gui() { if(layer) layer->set_player_locked(layerMan, !layer->get_player_locked()); }); + text_label(gui, "Layer defaults (Inherit → Person → World)"); + { + const CollabPermissionSet& layerSet = editingLayerLock->get_layer_defaults(); + left_to_right_line_layout(gui, [&]() { + for(uint8_t i = 0; i < static_cast(CollabRight::COUNT); i++) { + CollabRight right = static_cast(i); + gui.new_id(200 + i, [&] { + std::string label = std::string(collab_right_label(right)) + ":" + + collab_tristate_label(layerSet.get(right)); + text_button(gui, "layer perm", label.c_str(), { + .onClick = [&, right] { + auto layer = editingLayer.lock(); + if(!layer) + return; + CollabPermissionSet next = layer->get_layer_defaults(); + next.set(right, collab_cycle_tristate(next.get(right))); + layer->set_layer_defaults(layerMan, next); + } + }); + }); + } + }); + } + if(world.clients) { + text_label(gui, "Per-player overrides on this layer"); + size_t pnum = 0; + for(auto& client : world.clients->get_data()) { + if(client == world.ownClientData) + continue; + gui.new_id(300 + pnum++, [&] { + const std::string pname = client->get_display_name(); + text_label(gui, pname); + CollabPermissionSet overrideSet = CollabPermissionSet::all_inherit(); + auto it = editingLayerLock->get_person_layer_overrides().find(pname); + if(it != editingLayerLock->get_person_layer_overrides().end()) + overrideSet = it->second; + left_to_right_line_layout(gui, [&]() { + for(uint8_t i = 0; i < static_cast(CollabRight::COUNT); i++) { + CollabRight right = static_cast(i); + gui.new_id(i, [&] { + std::string label = std::string(collab_right_label(right)) + ":" + + collab_tristate_label(overrideSet.get(right)); + text_button(gui, "player layer perm", label.c_str(), { + .onClick = [&, right, pname] { + auto layer = editingLayer.lock(); + if(!layer) + return; + CollabPermissionSet next = CollabPermissionSet::all_inherit(); + auto found = layer->get_person_layer_overrides().find(pname); + if(found != layer->get_person_layer_overrides().end()) + next = found->second; + next.set(right, collab_cycle_tristate(next.get(right))); + layer->set_person_layer_override(layerMan, pname, next); + } + }); + }); + } + }); + }); + } + } } else text_label(gui, "Fog layers are always locked for players."); @@ -563,6 +632,7 @@ NetworkingObjects::NetObjOrderedListIterator Drawin auto insertedLayerPair = create_in_proper_position(newItem); auto& it = insertedLayerPair.second; + it->obj->apply_new_layer_permission_defaults(layerMan); world.undo.push(std::make_unique(std::make_unique(it->obj->get_undo_data(world.undo)), it->pos, world.undo.get_undoid_from_netid(insertedLayerPair.first), world.undo.get_undoid_from_netid(it->obj.get_net_id()))); world.main.g.gui.set_to_layout(); refresh_gui_data(); diff --git a/src/Toolbar.cpp b/src/Toolbar.cpp index 9cc1f4d..145fcdc 100644 --- a/src/Toolbar.cpp +++ b/src/Toolbar.cpp @@ -36,6 +36,8 @@ #include "RichText/TextStyleModifier.hpp" #include "VersionConstants.hpp" #include "World.hpp" +#include "ClientData.hpp" +#include "CollabPermissions.hpp" #include #include #include @@ -1205,33 +1207,84 @@ void Toolbar::color_palette(const char* id, Vector4f* color, const std::function } void Toolbar::player_list() { + using namespace GUIStuff; + using namespace ElementHelpers; auto& gui = main.g.gui; + auto& world = *main.world; + auto& layerMan = world.drawProg.layerMan; - center_obstructing_window_gui("player client list", CLAY_SIZING_FIT(500), CLAY_SIZING_FIT(0), [&] { + auto draw_perm_buttons = [&](const char* rowId, const CollabPermissionSet& shown, + const std::function& cycleRight) { + gui.new_id(rowId, [&] { + left_to_right_line_layout(gui, [&]() { + for(uint8_t i = 0; i < static_cast(CollabRight::COUNT); i++) { + CollabRight right = static_cast(i); + gui.new_id(i, [&] { + std::string label = std::string(collab_right_label(right)) + ":" + + collab_tristate_label(shown.get(right)); + text_button(gui, "perm", label.c_str(), { + .onClick = [cycleRight, right] { + cycleRight(right); + } + }); + }); + } + }); + }); + }; + + center_obstructing_window_gui("player client list", CLAY_SIZING_FIT(640), CLAY_SIZING_FIT(0), [&] { gui.new_id("client list", [&] { text_label_centered(gui, "Player List"); - if(!main.world->clientStillConnecting) { - if(main.world->netServer) { + if(!world.clientStillConnecting) { + if(world.netServer) { text_button(gui, "force all jump to host", "Bring Everyone Here", { .wide = true, .onClick = [&] { - main.world->drawProg.force_clients_to_own_view(); + world.drawProg.force_clients_to_own_view(); } }); + text_button(gui, "toggle session defaults", collabSessionDefaultsOpen ? "Hide Session Defaults" : "Session Defaults…", { + .wide = true, + .onClick = [&] { + collabSessionDefaultsOpen = !collabSessionDefaultsOpen; + } + }); + if(collabSessionDefaultsOpen) { + const CollabSessionDefaults& cur = world.drawProg.collab_defaults(); + text_label(gui, "World default (fallback when everything inherits)"); + draw_perm_buttons("world default row", cur.worldDefault, [&](CollabRight right) { + auto d = world.drawProg.collab_defaults(); + d.worldDefault.set(right, collab_cycle_tristate(d.worldDefault.get(right))); + world.drawProg.set_collab_defaults(d); + }); + text_label(gui, "New player defaults (copied on join)"); + draw_perm_buttons("new player default row", cur.newPlayerDefaults, [&](CollabRight right) { + auto d = world.drawProg.collab_defaults(); + d.newPlayerDefaults.set(right, collab_cycle_tristate(d.newPlayerDefaults.get(right))); + world.drawProg.set_collab_defaults(d); + }); + text_label(gui, "New layer defaults (copied on create)"); + draw_perm_buttons("new layer default row", cur.newLayerDefaults, [&](CollabRight right) { + auto d = world.drawProg.collab_defaults(); + d.newLayerDefaults.set(right, collab_cycle_tristate(d.newLayerDefaults.get(right))); + world.drawProg.set_collab_defaults(d); + }); + } } left_to_right_line_layout(gui, [&]() { CLAY_AUTO_ID({ .layout = { .sizing = {.width = CLAY_SIZING_FIXED(20), .height = CLAY_SIZING_FIXED(20)} }, - .backgroundColor = convert_vec4(SkColor4f{main.world->ownClientData->get_cursor_color().x(), main.world->ownClientData->get_cursor_color().y(), main.world->ownClientData->get_cursor_color().z(), 1.0f}), + .backgroundColor = convert_vec4(SkColor4f{world.ownClientData->get_cursor_color().x(), world.ownClientData->get_cursor_color().y(), world.ownClientData->get_cursor_color().z(), 1.0f}), .cornerRadius = CLAY_CORNER_RADIUS(3) }) {} - text_label(gui, main.world->ownClientData->get_display_name()); + text_label(gui, world.ownClientData->get_display_name() + " (you / host)"); }); size_t num = 0; - for(auto& client : main.world->clients->get_data()) { - if(client != main.world->ownClientData) { + for(auto& client : world.clients->get_data()) { + if(client != world.ownClientData) { gui.new_id(num++, [&] { left_to_right_line_layout(gui, [&]() { CLAY_AUTO_ID({ @@ -1244,15 +1297,40 @@ void Toolbar::player_list() { text_label(gui, client->get_display_name()); CLAY_AUTO_ID({.layout = {.sizing = {.width = CLAY_SIZING_GROW(0), .height = CLAY_SIZING_GROW(0)}}}) {} text_button(gui, "teleport button", "Jump To", { .onClick = [&] { - main.world->drawData.cam.smooth_move_to(*main.world, client->get_cam_coords(), client->get_window_size()); + world.drawData.cam.smooth_move_to(world, client->get_cam_coords(), client->get_window_size()); }}); + if(world.netServer) { + text_button(gui, "perms button", "Rights", { + .onClick = [&, name = client->get_display_name()] { + if(collabPermsExpandedPlayer == name) + collabPermsExpandedPlayer.clear(); + else + collabPermsExpandedPlayer = name; + } + }); + } }); + if(world.netServer && collabPermsExpandedPlayer == client->get_display_name()) { + text_label(gui, "Person defaults (Inherit → World)"); + NetworkingObjects::NetObjID clientId = client.get_net_id(); + draw_perm_buttons("person defaults", client->get_person_defaults(), [&, clientId](CollabRight right) { + auto peer = world.netObjMan.get_obj_temporary_ref_from_id(clientId); + if(!peer) + return; + CollabPermissionSet next = peer->get_person_defaults(); + next.set(right, collab_cycle_tristate(next.get(right))); + ClientData::set_person_defaults(peer, next); + layerMan.ensure_editing_layer_is_editable(); + }); + } }); } } } text_button(gui, "close list", "Done", { .wide = true, .onClick = [&] { playerMenuOpen = false; + collabSessionDefaultsOpen = false; + collabPermsExpandedPlayer.clear(); }}); }); }); diff --git a/src/Toolbar.hpp b/src/Toolbar.hpp index 05d4438..a243e8a 100644 --- a/src/Toolbar.hpp +++ b/src/Toolbar.hpp @@ -153,6 +153,8 @@ class Toolbar { bool menuPopUpOpen = false; bool optionsMenuOpen = false; bool playerMenuOpen = false; + bool collabSessionDefaultsOpen = false; + std::string collabPermsExpandedPlayer; float finalCalculatedGuiScale = 1.0f; diff --git a/src/VersionConstants.cpp b/src/VersionConstants.cpp index 2138525..1540978 100644 --- a/src/VersionConstants.cpp +++ b/src/VersionConstants.cpp @@ -32,6 +32,7 @@ VersionNumber header_to_version_number(const std::string& header) { m["INFPNT000006"] = VersionNumber(0, 6, 0); m["INFPNT000007"] = VersionNumber(0, 7, 0); m["INFPNT000008"] = VersionNumber(0, 8, 0); + m["INFPNT000009"] = VersionNumber(0, 9, 0); } auto it = m.find(header); if(it == m.end()) diff --git a/src/VersionConstants.hpp b/src/VersionConstants.hpp index d01c73f..4dfb13d 100644 --- a/src/VersionConstants.hpp +++ b/src/VersionConstants.hpp @@ -28,7 +28,7 @@ namespace VersionConstants { VersionNumber header_to_version_number(const std::string& header); constexpr int SAVEFILE_HEADER_LEN = 12; // DO NOT CHANGE THIS HEADER LENGTH - const std::string CURRENT_SAVEFILE_HEADER = "INFPNT000008"; // Change whenever the save file is incompatible with the previous version - const std::string CURRENT_VERSION_STRING = "0.8.0-fork"; - constexpr VersionNumber CURRENT_VERSION_NUMBER(0, 8, 0); + const std::string CURRENT_SAVEFILE_HEADER = "INFPNT000009"; // Change whenever the save file is incompatible with the previous version + const std::string CURRENT_VERSION_STRING = "0.9.0-fork"; + constexpr VersionNumber CURRENT_VERSION_NUMBER(0, 9, 0); } diff --git a/src/World.cpp b/src/World.cpp index 3cecd46..0a23226 100644 --- a/src/World.cpp +++ b/src/World.cpp @@ -70,6 +70,7 @@ World::World(MainProgram& initMain, const CustomEvents::OpenInfiniPaintFileEvent saveThumbnail = worldInfo.saveThumbnail; init_net_obj_type_list(); + drawProg.ensure_collab_defaults(); netObjMan.set_netobj_destroy_callback([&undo = undo](const NetworkingObjects::NetObjID& idToDestroy) { undo.remove_by_netid(idToDestroy); }); @@ -135,6 +136,7 @@ void World::init_net_obj_type_list() { NetworkingObjects::register_ordered_list_class(netObjMan); DrawingProgramLayerListItem::register_class(*this); NetworkingObjects::register_ordered_list_class(netObjMan); + DrawingProgram::register_collab_defaults_class(*this); canvasTheme.register_class(); ClientData::register_class(*this); NetworkingObjects::register_unordered_set_class(netObjMan); @@ -433,6 +435,7 @@ void World::start_hosting(const std::string& initNetSource, const std::string& s newClientData.camCoords = ownClientData->get_cam_coords(); newClientData.windowSize = ownClientData->get_window_size(); newClientData.gridSize = ownClientData->get_grid_size(); + newClientData.personDefaults = drawProg.collab_defaults().newPlayerDefaults; NetworkingObjects::NetObjTemporaryPtr clientDataObjPtr = clients->emplace_direct(clients, newClientData); client->customID = clientDataObjPtr.get_net_id().data;