copilot/infinipaint
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fixed eraser tool adding to mesh in rare cases

Browse source
This commit is contained in:
Yousef Khadadeh 2026-06-06 14:43:24 +03:00
parent c48531238e
commit ff99878755
3 changed files with 21 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/CanvasComponents/MeshCanvasComponent.cpp
View file

@ -374,13 +374,18 @@ CanvasComponentEraseDetailResult MeshCanvasComponent::erase_detail(const SkPath&
bool intersectsAABB = d.meshPath.getBounds().intersects(eraseAgainst.getBounds());
if(!intersectsAABB)
return CanvasComponentEraseDetailResult::NO_CHANGE;
std::optional<SkPath> newPath = Op(d.meshPath, eraseAgainst, SkPathOp::kDifference_SkPathOp);
std::optional<SkPath> newPath = Op(Simplify(d.meshPath).value(), Simplify(eraseAgainst).value(), SkPathOp::kDifference_SkPathOp);
if(newPath.has_value()) {
auto oldPath = d.meshPath;
d.meshPath = newPath.value();
if(d.meshPath.isEmpty())
if(newPath.value().isEmpty()) {
d.meshPath = newPath.value();
return CanvasComponentEraseDetailResult::REMOVED;
return CanvasComponentEraseDetailResult::CHANGED;
}
else if(!d.meshPath.getBounds().contains(newPath.value().getBounds())) // If bounds of erased path is larger than bounds of original path (can happen when difference op bugs out with big eraser paths), dont change the path
return CanvasComponentEraseDetailResult::NO_CHANGE;
else {
d.meshPath = newPath.value();
return CanvasComponentEraseDetailResult::CHANGED;
}
}
return CanvasComponentEraseDetailResult::NO_CHANGE;
}