Fixed some memory leaks and uses of uninitialized values

src/DrawComponents/DrawComponent.hpp

@@ -76,7 +76,7 @@ class DrawComponent {
 
         std::weak_ptr<CollabListType::ObjectInfo> collabListInfo;
         std::weak_ptr<DrawingProgramCacheBVHNode> parentBvhNode;
-        ServerClientID id;
+        ServerClientID id = {0, 0};
 
 #ifndef IS_SERVER
         std::chrono::time_point<std::chrono::steady_clock> lastUpdateTime;

src/DrawingProgram/DrawingProgram.cpp

@@ -359,6 +359,11 @@ void DrawingProgram::update() {
     selection.update();
     drawTool->tool_update();
 
+    if(toolToSwitchToAfterUpdate) {
+        switch_to_tool_ptr(std::move(toolToSwitchToAfterUpdate));
+        toolToSwitchToAfterUpdate = nullptr;
+    }
+
     if(controls.leftClickReleased)
         controls.leftClickReleased = false;
 

src/DrawingProgram/DrawingProgram.hpp

@@ -93,6 +93,8 @@ class DrawingProgram {
 
         DrawingProgramSelection selection;
 
+        std::unique_ptr<DrawingProgramToolBase> toolToSwitchToAfterUpdate;
+
         bool temporaryEraser = false;
         bool temporaryPan = false;
         DrawingProgramToolType toolTypeAfterTempPan;

src/DrawingProgram/EllipseDrawEditTool.cpp

@@ -40,10 +40,10 @@ bool EllipseDrawEditTool::edit_gui(const std::shared_ptr<DrawComponent>& comp) {
         });
     }
     t.gui.pop_id();
-    
-    bool editHappened = a->d != oldData;
+ 
+    bool editHappened = (!oldData.has_value()) || (a->d != oldData);
     oldData = a->d;
-    return editHappened;
+    return editHappened;   
 }
 
 void EllipseDrawEditTool::edit_start(EditTool& editTool, const std::shared_ptr<DrawComponent>& comp, std::any& prevData) {

src/DrawingProgram/EllipseDrawEditTool.hpp

@@ -16,5 +16,5 @@ class EllipseDrawEditTool : public DrawingProgramEditToolBase {
     private:
         void commit();
 
-        DrawEllipse::Data oldData;
+        std::optional<DrawEllipse::Data> oldData;
 };

src/DrawingProgram/RectDrawEditTool.cpp

@@ -39,7 +39,7 @@ bool RectDrawEditTool::edit_gui(const std::shared_ptr<DrawComponent>& comp) {
     }
     t.gui.pop_id();
 
-    bool editHappened = a->d != oldData;
+    bool editHappened = (!oldData.has_value()) || (a->d != oldData);
     oldData = a->d;
     return editHappened;
 }

src/DrawingProgram/RectDrawEditTool.hpp

@@ -14,5 +14,5 @@ class RectDrawEditTool : public DrawingProgramEditToolBase {
         virtual bool edit_update(const std::shared_ptr<DrawComponent>& comp) override;
         virtual bool edit_gui(const std::shared_ptr<DrawComponent>& comp) override;
     private:
-        DrawRectangle::Data oldData;
+        std::optional<DrawRectangle::Data> oldData;
 };

src/DrawingProgram/TextBoxEditTool.cpp

@@ -26,7 +26,7 @@ bool TextBoxEditTool::edit_gui(const std::shared_ptr<DrawComponent>& comp) {
         t.gui.text_label("Text Color");
     });
     t.gui.pop_id();
-    bool editHappened = a->d != oldData;
+    bool editHappened = (!oldData.has_value()) || (a->d != oldData);
     oldData = a->d;
     return editHappened;
 }

src/DrawingProgram/TextBoxEditTool.hpp

@@ -18,5 +18,5 @@ class TextBoxEditTool : public DrawingProgramEditToolBase {
         void edit_text(std::function<void()> toRun, const std::shared_ptr<DrawTextBox>& textBox);
         void update_textbox_network(const std::shared_ptr<DrawTextBox>& textBox);
 
-        DrawTextBox::Data oldData;
+        std::optional<DrawTextBox::Data> oldData;
 };

src/DrawingProgram/TextBoxTool.cpp

@@ -67,7 +67,7 @@ void TextBoxTool::tool_update() {
             if(!drawP.controls.leftClickHeld) {
                 auto editTool = std::make_unique<EditTool>(drawP);
                 editTool->edit_start(controls.intermediateItem);
-                drawP.switch_to_tool_ptr(std::move(editTool));
+                drawP.toolToSwitchToAfterUpdate = std::move(editTool);
                 return;
             }
             else {

src/MainProgram.cpp

@@ -97,14 +97,6 @@ void MainProgram::update() {
 
     deltaTime.update_time_since();
     deltaTime.update_time_point();
-    
-    toolbar.update();
-
-    if(input.key(InputManager::KEY_NOGUI).pressed)
-        drawGui = !drawGui;
-
-    if(input.key(InputManager::KEY_FULLSCREEN).pressed)
-        input.toggleFullscreen = true;
 
     for(auto& w : worlds) {
         if(w == world)
@@ -113,6 +105,14 @@ void MainProgram::update() {
             w->unfocus_update();
     }
 
+    toolbar.update(); // GUI should be setup after the world data has been fully updated for this frame, so that the GUI reflects the current state of the world data
+
+    if(input.key(InputManager::KEY_NOGUI).pressed)
+        drawGui = !drawGui;
+
+    if(input.key(InputManager::KEY_FULLSCREEN).pressed)
+        input.toggleFullscreen = true;
+
     NetLibrary::update();
 
     if(tabSetToOpen) {

src/World.hpp

@@ -85,7 +85,7 @@ class World {
         void undo_with_checks();
         void redo_with_checks();
 
-        ServerPortionID ownID;
+        ServerPortionID ownID = 0;
 
         std::filesystem::path filePath;
         Vector3f userColor = {0.0f, 0.0f, 0.0f};
@@ -95,8 +95,8 @@ class World {
         void set_canvas_background_color(const Vector3f& newBackColor, bool sendChangeOverNetwork = true);
 
         struct CanvasTheme {
-            SkColor4f backColor;
-            SkColor4f toolFrontColor;
+            SkColor4f backColor = {0.0f, 0.0f, 0.0f, 1.0f};
+            SkColor4f toolFrontColor = {1.0f, 1.0f, 1.0f, 1.0f};
         } canvasTheme;
 
         void scale_up(const WorldScalar& scaleUpAmount);