Squash-merge commit. Covers four areas: native video player, chat reliability, multi-tab, and hardening. ## Native video player - Direct HLS playback via `better_native_video_player` (forked from `plug-and-pay/flutter-native-video-player`, patched on `frosty-patches` branch) - Twitch GQL playback token fetching with platform cookie extraction (iOS Swift + Android Kotlin plugins) for authenticated streams - Quality selection (source, 720p, 480p, 360p, 160p, audio-only) persisted per channel - Picture-in-picture: iOS automatic inline PiP, Android auto-PiP on API 31+ guarded against older devices - Latency polling, chat latency sync, stall detection/recovery, startup auto-pause recovery, watchdog timers - **Twitch stitched-ad break detection** (HLS `EXT-X-DATERANGE`) on both platforms, emitting `adBreakChanged` so the host suspends latency/stall recovery and chat sync during ads (program-date-time is unreliable then). Matches `CLASS="twitch-stitched-ad"` / `ID="stitched-ad-"` **and** the `X-TV-TWITCH-AD-*` attribute prefix (the durable signal streamlink/yt-dlp use) - Shared `VideoPlayerInterface` so WebView and native paths are interchangeable via settings toggle - `PlaybackAccessToken` model, `TwitchGqlApi` client ## Chat delay & send reliability - **Optimistic send-finalize**: Twitch acks a sent message with a per-PRIVMSG USERSTATE (not an echo), which it can intermittently drop — more so under a long chat delay. A missing ack no longer shows a false "message may not have been sent" error; the send is finalized optimistically (local echo rendered), and only genuine rejection NOTICEs surface an error. Ack timeout scaled by the chat delay. - **Per-line chat-delay bypass**: control/state lines (USERSTATE/ROOMSTATE/GLOBALUSERSTATE), rejection NOTICEs, the reconnect notice, and untagged server lines bypass the delay so send-acks and PONGs aren't stalled; only displayable chat content is delayed, staying in sync with delayed video. - **Measured chat bottom-bar height**: the message list reflows to the composer's real measured height, fixing the input overlapping messages when a long message expands it (replaces a fixed-constant estimate). - IRC tag parsing handles valueless and escaped tags per the IRCv3 message-tags spec (fixes a recent-messages RangeError on certain tags). ## Chat / multi-tab - Redesigned tab chips: unread dot indicator, chips dim until WebSocket connects - Animated tab options popover replacing `MenuAnchor` (no animation hook in Flutter 3.44) - Simplified `ChatTabs` from `StatefulWidget` to `StatelessWidget` - Focus-current-channel fade bump to 0.55; section-header alpha lifted to match the muted-label tier - `addTab` now calls `setActiveTab` to snapshot outgoing tab's `lastSeenMessageId` — fixes spurious unread dots after adding a tab - `onActivateSourceTab` threaded into `ChatUserModal` so Reply in merged mode switches to the correct source tab's composer ## Bug fixes and hardening - **Reverted the experimental iOS low-latency mode** (5s live-edge join + 1.05x catch-up): AVPlayer can't sustain <~18s on Twitch (declared `TARGETDURATION:6` paces playlist refreshes), and the offset starved the buffer into pause-on-launch. Default join distance restored. - Fork (Android): **cap `BEHIND_LIVE_WINDOW` recovery** so a stream repeatedly falling off the live window can't silently re-prepare forever; emits `error` on exhaustion so the host recovery ladder takes over - Guard all Android `setAutoPipMode` calls with `_autoPipAvailable` — prevents `PlatformException` on Android 8–11; check `_disposed` after `isAutoPipAvailable` await to prevent post-dispose auto-PiP re-enable - Remove `_isInPipMode` guard from `_onPaused` so `_paused` tracks actual state, fixing PiP play/pause toggle getting stuck - Tighten iOS cookie domain check to exact `twitch.tv` / `.twitch.tv` suffix - Invalidate the stored web session token when Twitch rejects it with a 401 (profile card flips back to unlinked; future loads skip the doomed authenticated request), and re-extract the cookie on launch when logged in without a linked session - Send `play_session_id` and `player_backend=mediaplayer` to Usher, matching the web client / streamlink - Fork (iOS): restore program-date-time latency measurement (a prior rev measured distance to the manifest edge, reading ~0s and silently disabling high-latency recovery / chat-delay auto-sync); release platform views on dispose (per-stream view + AVPlayerViewController leak), track the observed AVPlayerItem for KVO removal (sibling-view crash), main-thread seek results, resolve superseded load futures - Fork (Android): clean up method handlers orphaned by PiP-time view disposal (leaked audio-focus listeners), drop the live-offset re-anchoring seekTo on metadata updates (latency creep), restore pre-duck volume, respect user pause in the stall watchdog, resolve superseded load futures - Deep review pass: expire the quality-switch flag so stall recovery isn't disabled for the session, cap latency-driven recovery (clock-skew loop), generation-guard the error overlay, two-strike offline confirmation, controller null-safety on quality switch - Tighten `/me` local-echo match (no longer renders `/meow ...` as an action); clear pending send text on disconnect ## Web / docs - Remove stale Cloudflare Images binding from `wrangler.jsonc` (covered by `images.unoptimized: true`) - Correct `web/AGENTS.md` Cache Components claim (feature not enabled) - Repo and agent config cleanup ## Test plan - [x] `flutter analyze` — clean (frosty + plugin lib) - [x] `flutter test` — 319/319 pass (adds `ChatLatencySync`, `StreamInfoPoller`, video timing invariants, `PlaybackAccessToken`, IRC tag parsing) - [x] Android plugin Kotlin compiles against the bumped fork rev - [ ] Native player plays live streams on iOS and Android - [ ] Quality switching works and persists across channel reopens - [ ] PiP enters/exits correctly; pause/resume toggle in PiP window works - [ ] Audio-only mode does not crash on Android < API 31 - [ ] Sending under a long synced chat delay no longer shows a false "may not have been sent" error - [ ] Long composer text reflows the message list (no input/message overlap) - [ ] Multi-tab: adding a tab does not mark previous tab as unread - [ ] Merged chat: Reply from user modal targets the correct tab's composer 🤖 Generated with [Claude Code](https://claude.com/claude-code)
194 lines
6 KiB
Dart
194 lines
6 KiB
Dart
import 'dart:async';
|
|
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:frosty/apis/twitch_api.dart';
|
|
import 'package:frosty/models/channel.dart';
|
|
import 'package:frosty/models/stream.dart';
|
|
import 'package:frosty/screens/channel/video/stream_info_poller.dart';
|
|
import 'package:mocktail/mocktail.dart';
|
|
|
|
import '../../../fixtures/api_responses.dart';
|
|
|
|
class MockTwitchApi extends Mock implements TwitchApi {}
|
|
|
|
void main() {
|
|
const userLogin = 'testuser';
|
|
const userId = '12345';
|
|
|
|
late MockTwitchApi api;
|
|
|
|
// Fresh fixtures per test so nothing leaks between cases.
|
|
StreamTwitch buildStream() => StreamTwitch.fromJson(
|
|
(twitchStreamResponse['data']! as List).first as Map<String, dynamic>,
|
|
);
|
|
|
|
Channel buildChannel() => Channel.fromJson(
|
|
(twitchChannelResponse['data']! as List).first as Map<String, dynamic>,
|
|
);
|
|
|
|
// Fresh poller per test so _lastUpdate / _inFlight debounce state never
|
|
// carries over between tests.
|
|
StreamInfoPoller buildPoller() =>
|
|
StreamInfoPoller(twitchApi: api, userLogin: userLogin, userId: userId);
|
|
|
|
setUp(() {
|
|
api = MockTwitchApi();
|
|
});
|
|
|
|
group('live', () {
|
|
test('returns stream when getStream succeeds', () async {
|
|
when(
|
|
() => api.getStream(userLogin: any(named: 'userLogin')),
|
|
).thenAnswer((_) async => buildStream());
|
|
|
|
final poller = buildPoller();
|
|
final result = await poller.fetch();
|
|
|
|
expect(result, isNotNull);
|
|
expect(result!.stream, isNotNull);
|
|
expect(result.stream!.userName, 'TestUser');
|
|
expect(result.offlineChannel, isNull);
|
|
|
|
verify(() => api.getStream(userLogin: userLogin)).called(1);
|
|
verifyNever(() => api.getChannel(userId: any(named: 'userId')));
|
|
});
|
|
});
|
|
|
|
group('debounce', () {
|
|
test(
|
|
'second fetch within debounce window returns null, forceUpdate bypasses',
|
|
() async {
|
|
when(
|
|
() => api.getStream(userLogin: any(named: 'userLogin')),
|
|
).thenAnswer((_) async => buildStream());
|
|
|
|
final poller = buildPoller();
|
|
|
|
// First fetch resolves with a real result.
|
|
final first = await poller.fetch();
|
|
expect(first, isNotNull);
|
|
expect(first!.stream, isNotNull);
|
|
|
|
// Immediate second fetch (no forceUpdate) is inside the 5s debounce
|
|
// window -> debounced -> null.
|
|
final second = await poller.fetch();
|
|
expect(second, isNull);
|
|
|
|
// forceUpdate bypasses the debounce -> a fresh result.
|
|
final forced = await poller.fetch(forceUpdate: true);
|
|
expect(forced, isNotNull);
|
|
expect(forced!.stream, isNotNull);
|
|
|
|
// Two real fetches (first + forced); the debounced one issued no call.
|
|
verify(() => api.getStream(userLogin: userLogin)).called(2);
|
|
},
|
|
);
|
|
});
|
|
|
|
group('in-flight dedup', () {
|
|
test(
|
|
'concurrent fetches await the same request and call getStream once',
|
|
() async {
|
|
final completer = Completer<StreamTwitch>();
|
|
when(
|
|
() => api.getStream(userLogin: any(named: 'userLogin')),
|
|
).thenAnswer((_) => completer.future);
|
|
|
|
final poller = buildPoller();
|
|
|
|
// Fire both without awaiting so the second sees the in-flight future.
|
|
final firstFuture = poller.fetch();
|
|
final secondFuture = poller.fetch();
|
|
|
|
// Now let the underlying request complete.
|
|
completer.complete(buildStream());
|
|
|
|
final first = await firstFuture;
|
|
final second = await secondFuture;
|
|
|
|
expect(first, isNotNull);
|
|
expect(second, isNotNull);
|
|
// Same deduplicated result instance.
|
|
expect(identical(first, second), isTrue);
|
|
expect(first!.stream, isNotNull);
|
|
|
|
verify(() => api.getStream(userLogin: userLogin)).called(1);
|
|
},
|
|
);
|
|
});
|
|
|
|
group('second-chance retry', () {
|
|
test(
|
|
'getStream fails once then succeeds on retry -> stream, no getChannel',
|
|
() async {
|
|
var calls = 0;
|
|
when(() => api.getStream(userLogin: any(named: 'userLogin'))).thenAnswer(
|
|
(_) async {
|
|
calls++;
|
|
if (calls == 1) throw Exception('transient drop');
|
|
return buildStream();
|
|
},
|
|
);
|
|
|
|
final poller = buildPoller();
|
|
final result = await poller.fetch();
|
|
|
|
expect(result, isNotNull);
|
|
expect(result!.stream, isNotNull);
|
|
expect(result.offlineChannel, isNull);
|
|
|
|
verify(() => api.getStream(userLogin: userLogin)).called(2);
|
|
verifyNever(() => api.getChannel(userId: any(named: 'userId')));
|
|
},
|
|
);
|
|
});
|
|
|
|
group('offline', () {
|
|
test(
|
|
'getStream fails twice, getChannel succeeds -> offlineChannel',
|
|
() async {
|
|
when(
|
|
() => api.getStream(userLogin: any(named: 'userLogin')),
|
|
).thenThrow(Exception('offline'));
|
|
when(
|
|
() => api.getChannel(userId: any(named: 'userId')),
|
|
).thenAnswer((_) async => buildChannel());
|
|
|
|
final poller = buildPoller();
|
|
final result = await poller.fetch();
|
|
|
|
expect(result, isNotNull);
|
|
expect(result!.stream, isNull);
|
|
expect(result.offlineChannel, isNotNull);
|
|
expect(result.offlineChannel!.broadcasterName, 'TestUser');
|
|
|
|
verify(() => api.getStream(userLogin: userLogin)).called(2);
|
|
verify(() => api.getChannel(userId: userId)).called(1);
|
|
},
|
|
);
|
|
});
|
|
|
|
group('total failure', () {
|
|
test(
|
|
'getStream fails twice and getChannel fails -> empty result',
|
|
() async {
|
|
when(
|
|
() => api.getStream(userLogin: any(named: 'userLogin')),
|
|
).thenThrow(Exception('stream boom'));
|
|
when(
|
|
() => api.getChannel(userId: any(named: 'userId')),
|
|
).thenThrow(Exception('channel boom'));
|
|
|
|
final poller = buildPoller();
|
|
final result = await poller.fetch();
|
|
|
|
expect(result, isNotNull);
|
|
expect(result!.stream, isNull);
|
|
expect(result.offlineChannel, isNull);
|
|
|
|
verify(() => api.getStream(userLogin: userLogin)).called(2);
|
|
verify(() => api.getChannel(userId: userId)).called(1);
|
|
},
|
|
);
|
|
});
|
|
}
|