frosty/lib/screens/channel/chat/details/chat_modes.dart
Tommy Chow f2b932bc93
feat(video,chat): native player, ad-break awareness, chat send/delay reliability, and tab redesign (#567)
Squash-merge commit. Covers four areas: native video player, chat reliability, multi-tab, and hardening.

## Native video player
- Direct HLS playback via `better_native_video_player` (forked from `plug-and-pay/flutter-native-video-player`, patched on `frosty-patches` branch)
- Twitch GQL playback token fetching with platform cookie extraction (iOS Swift + Android Kotlin plugins) for authenticated streams
- Quality selection (source, 720p, 480p, 360p, 160p, audio-only) persisted per channel
- Picture-in-picture: iOS automatic inline PiP, Android auto-PiP on API 31+ guarded against older devices
- Latency polling, chat latency sync, stall detection/recovery, startup auto-pause recovery, watchdog timers
- **Twitch stitched-ad break detection** (HLS `EXT-X-DATERANGE`) on both platforms, emitting `adBreakChanged` so the host suspends latency/stall recovery and chat sync during ads (program-date-time is unreliable then). Matches `CLASS="twitch-stitched-ad"` / `ID="stitched-ad-"` **and** the `X-TV-TWITCH-AD-*` attribute prefix (the durable signal streamlink/yt-dlp use)
- Shared `VideoPlayerInterface` so WebView and native paths are interchangeable via settings toggle
- `PlaybackAccessToken` model, `TwitchGqlApi` client

## Chat delay & send reliability
- **Optimistic send-finalize**: Twitch acks a sent message with a per-PRIVMSG USERSTATE (not an echo), which it can intermittently drop — more so under a long chat delay. A missing ack no longer shows a false "message may not have been sent" error; the send is finalized optimistically (local echo rendered), and only genuine rejection NOTICEs surface an error. Ack timeout scaled by the chat delay.
- **Per-line chat-delay bypass**: control/state lines (USERSTATE/ROOMSTATE/GLOBALUSERSTATE), rejection NOTICEs, the reconnect notice, and untagged server lines bypass the delay so send-acks and PONGs aren't stalled; only displayable chat content is delayed, staying in sync with delayed video.
- **Measured chat bottom-bar height**: the message list reflows to the composer's real measured height, fixing the input overlapping messages when a long message expands it (replaces a fixed-constant estimate).
- IRC tag parsing handles valueless and escaped tags per the IRCv3 message-tags spec (fixes a recent-messages RangeError on certain tags).

## Chat / multi-tab
- Redesigned tab chips: unread dot indicator, chips dim until WebSocket connects
- Animated tab options popover replacing `MenuAnchor` (no animation hook in Flutter 3.44)
- Simplified `ChatTabs` from `StatefulWidget` to `StatelessWidget`
- Focus-current-channel fade bump to 0.55; section-header alpha lifted to match the muted-label tier
- `addTab` now calls `setActiveTab` to snapshot outgoing tab's `lastSeenMessageId` — fixes spurious unread dots after adding a tab
- `onActivateSourceTab` threaded into `ChatUserModal` so Reply in merged mode switches to the correct source tab's composer

## Bug fixes and hardening
- **Reverted the experimental iOS low-latency mode** (5s live-edge join + 1.05x catch-up): AVPlayer can't sustain <~18s on Twitch (declared `TARGETDURATION:6` paces playlist refreshes), and the offset starved the buffer into pause-on-launch. Default join distance restored.
- Fork (Android): **cap `BEHIND_LIVE_WINDOW` recovery** so a stream repeatedly falling off the live window can't silently re-prepare forever; emits `error` on exhaustion so the host recovery ladder takes over
- Guard all Android `setAutoPipMode` calls with `_autoPipAvailable` — prevents `PlatformException` on Android 8–11; check `_disposed` after `isAutoPipAvailable` await to prevent post-dispose auto-PiP re-enable
- Remove `_isInPipMode` guard from `_onPaused` so `_paused` tracks actual state, fixing PiP play/pause toggle getting stuck
- Tighten iOS cookie domain check to exact `twitch.tv` / `.twitch.tv` suffix
- Invalidate the stored web session token when Twitch rejects it with a 401 (profile card flips back to unlinked; future loads skip the doomed authenticated request), and re-extract the cookie on launch when logged in without a linked session
- Send `play_session_id` and `player_backend=mediaplayer` to Usher, matching the web client / streamlink
- Fork (iOS): restore program-date-time latency measurement (a prior rev measured distance to the manifest edge, reading ~0s and silently disabling high-latency recovery / chat-delay auto-sync); release platform views on dispose (per-stream view + AVPlayerViewController leak), track the observed AVPlayerItem for KVO removal (sibling-view crash), main-thread seek results, resolve superseded load futures
- Fork (Android): clean up method handlers orphaned by PiP-time view disposal (leaked audio-focus listeners), drop the live-offset re-anchoring seekTo on metadata updates (latency creep), restore pre-duck volume, respect user pause in the stall watchdog, resolve superseded load futures
- Deep review pass: expire the quality-switch flag so stall recovery isn't disabled for the session, cap latency-driven recovery (clock-skew loop), generation-guard the error overlay, two-strike offline confirmation, controller null-safety on quality switch
- Tighten `/me` local-echo match (no longer renders `/meow ...` as an action); clear pending send text on disconnect

## Web / docs
- Remove stale Cloudflare Images binding from `wrangler.jsonc` (covered by `images.unoptimized: true`)
- Correct `web/AGENTS.md` Cache Components claim (feature not enabled)
- Repo and agent config cleanup

## Test plan
- [x] `flutter analyze` — clean (frosty + plugin lib)
- [x] `flutter test` — 319/319 pass (adds `ChatLatencySync`, `StreamInfoPoller`, video timing invariants, `PlaybackAccessToken`, IRC tag parsing)
- [x] Android plugin Kotlin compiles against the bumped fork rev
- [ ] Native player plays live streams on iOS and Android
- [ ] Quality switching works and persists across channel reopens
- [ ] PiP enters/exits correctly; pause/resume toggle in PiP window works
- [ ] Audio-only mode does not crash on Android < API 31
- [ ] Sending under a long synced chat delay no longer shows a false "may not have been sent" error
- [ ] Long composer text reflows the message list (no input/message overlap)
- [ ] Multi-tab: adding a tab does not mark previous tab as unread
- [ ] Merged chat: Reply from user modal targets the correct tab's composer

🤖 Generated with [Claude Code](https://claude.com/claude-code)
2026-06-13 17:06:24 -04:00

183 lines
5.3 KiB
Dart

import 'package:flutter/material.dart';
import 'package:flutter_mobx/flutter_mobx.dart';
import 'package:frosty/models/irc.dart';
import 'package:frosty/utils/context_extensions.dart';
class ChatModes extends StatelessWidget {
final ROOMSTATE roomState;
const ChatModes({super.key, required this.roomState});
String pluralize(String str, String count) => count == '1' ? str : '${str}s';
@override
Widget build(BuildContext context) {
return Observer(
builder: (context) {
final activeModes = <MapEntry<String, Widget>>[];
// Collect active modes with their labels for sorting
if (roomState.emoteOnly != '0') {
activeModes.add(
MapEntry(
'Emote only',
_buildModeChip(
context: context,
icon: Icons.emoji_emotions_outlined,
activeIcon: Icons.emoji_emotions_rounded,
label: 'Emote only',
activeLabel: 'Emote only',
isActive: true,
activeColor: context.frostyColors.emoteOnly,
),
),
);
}
if (roomState.followersOnly != '-1') {
activeModes.add(
MapEntry(
'Follower only',
_buildModeChip(
context: context,
icon: Icons.favorite_outline_rounded,
activeIcon: Icons.favorite_rounded,
label: 'Follower only',
activeLabel: 'Follower only',
isActive: true,
activeColor: context.frostyColors.followersOnly,
duration: _getFollowersDuration(),
),
),
);
}
if (roomState.slowMode != '0') {
activeModes.add(
MapEntry(
'Slow mode',
_buildModeChip(
context: context,
icon: Icons.hourglass_empty_rounded,
activeIcon: Icons.hourglass_top_rounded,
label: 'Slow mode',
activeLabel: 'Slow mode',
isActive: true,
activeColor: context.frostyColors.slowMode,
duration: _getSlowModeDuration(),
),
),
);
}
if (roomState.subMode != '0') {
activeModes.add(
MapEntry(
'Sub only',
_buildModeChip(
context: context,
icon: Icons.monetization_on_outlined,
activeIcon: Icons.monetization_on_rounded,
label: 'Sub only',
activeLabel: 'Sub only',
isActive: true,
activeColor: context.frostyColors.subOnly,
),
),
);
}
if (roomState.r9k != '0') {
activeModes.add(
MapEntry(
'Unique mode',
_buildModeChip(
context: context,
icon: Icons.quiz_outlined,
activeIcon: Icons.quiz_rounded,
label: 'Unique mode',
activeLabel: 'Unique mode',
isActive: true,
activeColor: context.frostyColors.uniqueMode,
),
),
);
}
// Sort alphabetically by label
activeModes.sort((a, b) => a.key.compareTo(b.key));
final activeChips = activeModes.map((entry) => entry.value).toList();
return Wrap(spacing: 8, runSpacing: -4, children: activeChips);
},
);
}
String? _getFollowersDuration() {
if (roomState.followersOnly == '0') {
return null; // No duration for immediate followers
}
final minutes = int.parse(roomState.followersOnly);
if (minutes >= 60) {
final hours = minutes ~/ 60;
final remainingMinutes = minutes % 60;
if (remainingMinutes == 0) {
return '${hours}h';
} else {
return '${hours}h ${remainingMinutes}m';
}
}
return '${minutes}m';
}
String _getSlowModeDuration() {
final seconds = int.parse(roomState.slowMode);
if (seconds >= 60) {
final minutes = seconds ~/ 60;
final remainingSeconds = seconds % 60;
if (remainingSeconds == 0) {
return '${minutes}m';
} else {
return '${minutes}m ${remainingSeconds}s';
}
}
return '${seconds}s';
}
Widget _buildModeChip({
required BuildContext context,
required IconData icon,
required IconData activeIcon,
required String label,
required String activeLabel,
required bool isActive,
required Color activeColor,
String? duration,
}) {
return Chip(
avatar: Icon(
isActive ? activeIcon : icon,
size: 16,
color: isActive ? activeColor : null,
),
label: duration != null
? Row(
mainAxisSize: MainAxisSize.min,
children: [
Text(isActive ? activeLabel : label),
const SizedBox(width: 4),
Text(
duration,
style: TextStyle(
color: Theme.of(
context,
).colorScheme.onSurfaceVariant.withValues(alpha: 0.7),
),
),
],
)
: Text(isActive ? activeLabel : label),
side: BorderSide.none,
);
}
}