copilot/frosty
1
0
Fork 0
Code Issues Pull requests Projects Releases 11 Packages Wiki Activity Actions

feat(video): make the native player the default

Browse source 
5.1.0 already serialized useNativePlayer: false, so existing installs
need a one-shot migrate. WebView stays as a legacy opt-out.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Tommy Chow 2026-08-16 12:21:44 -07:00
parent dc444810b1
commit fcd7a304e8
5 changed files with 73 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

31
test/screens/settings/stores/settings_store_test.dart
View file

@ -14,6 +14,7 @@ void main() {
expect(store.showVideo, isTrue);
expect(store.defaultToHighestQuality, isFalse);
expect(store.useTextureRendering, isTrue);
expect(store.useNativePlayer, isTrue);
expect(store.showOverlay, isTrue);
expect(store.toggleableOverlay, isFalse);
expect(store.showLatency, isFalse);
@ -102,6 +103,34 @@ void main() {
});
});
group('native player default migration', () {
test('5.1.0 WebView default is flipped on once', () {
final store = SettingsStore.fromJson({'useNativePlayer': false});
expect(store.useNativePlayer, isTrue);
expect(store.nativePlayerV52Migrated, isTrue);
});
test('opt-out is kept after the one-shot migration', () {
final store = SettingsStore.fromJson({
'useNativePlayer': false,
'nativePlayerV52Migrated': true,
});
expect(store.useNativePlayer, isFalse);
});
test('roundtrip after opt-out stays on WebView', () {
final store = SettingsStore.fromJson({});
store.useNativePlayer = false;
final restored = SettingsStore.fromJson(store.toJson());
expect(restored.useNativePlayer, isFalse);
expect(restored.nativePlayerV52Migrated, isTrue);
});
});
group('SettingsStore reset actions', () {
test('resetGeneralSettings restores general defaults', () {
final store = SettingsStore.fromJson({});
@ -127,6 +156,7 @@ void main() {
store.showVideo = false;
store.defaultToHighestQuality = true;
store.useTextureRendering = false;
store.useNativePlayer = false;
store.showOverlay = false;
store.toggleableOverlay = true;
store.showLatency = true;
@ -136,6 +166,7 @@ void main() {
expect(store.showVideo, isTrue);
expect(store.defaultToHighestQuality, isFalse);
expect(store.useTextureRendering, isTrue);
expect(store.useNativePlayer, isTrue);
expect(store.showOverlay, isTrue);
expect(store.toggleableOverlay, isFalse);
expect(store.showLatency, isFalse);