fix recent messages by handling valueless and escaped irc tags

The recent-messages API now serializes empty IRCv3 tags as bare keys
(e.g. `emotes`) instead of `emotes=`, which threw a RangeError in the
tag parser and silently dropped every recent message. Parse tags per the
IRCv3 spec: treat bare and empty values as equivalent, split on the first
`=` so values may contain `=`, and unescape values in a single pass
(\: \s \ \r \n). Also guard user extraction against prefixes without
`!`, and isolate per-message parse failures in _handleIRCData so one bad
message can no longer abort an entire batch.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Tommy Chow 2026-06-08 21:53:53 -07:00
parent 2b81f2cb31
commit c27a37d52f
4 changed files with 144 additions and 20 deletions

View file

@ -27,6 +27,27 @@ void main() {
expect(msg.message, 'test message');
});
test('unescapes the full IRCv3 tag escape set', () {
final msg = IRCMessage.fromString(messageWithEscapedTagChars);
expect(msg.tags['a-space'], 'one two');
expect(msg.tags['a-semi'], 'left;right');
expect(msg.tags['a-slash'], r'a\b');
// Only the first '=' splits key/value; later '=' stays in the value.
expect(msg.tags['a-equals'], 'k=v');
// `\\` consumes both backslashes; the following 's' is a literal letter,
// not a `\s` space escape (single-pass unescaping).
expect(msg.tags['a-double'], r'x\sy');
});
test('falls back to login tag when prefix has no "!"', () {
// An unexpected prefix shape must not throw and drop the message.
final msg = IRCMessage.fromString(messageNoBangPrefix);
expect(msg.user, 'fallbackuser');
expect(msg.message, 'server style');
});
test('handles message with no color tag', () {
final msg = IRCMessage.fromString(messageNoColor);
@ -223,6 +244,20 @@ void main() {
expect(msg.tags['historical'], '1');
});
test('parses historical message with bare (valueless) tags', () {
// The recent-messages API serializes empty tags as bare keys (e.g.
// `emotes`, `flags`) instead of `key=`. This previously threw a
// RangeError, silently dropping all recent messages.
final msg = IRCMessage.fromString(historicalMessageBareTags);
expect(msg.tags['historical'], '1');
expect(msg.tags['display-name'], 'BareUser');
expect(msg.message, 'Bare tag message');
// Bare tags should be absent from the map, not crash parsing.
expect(msg.tags.containsKey('emotes'), isFalse);
expect(msg.tags.containsKey('flags'), isFalse);
});
test('parses shared chat message with source room', () {
final msg = IRCMessage.fromString(sharedChatMessage);