rename enhanced rendering setting to reset for all users

This commit is contained in:
Tommy Chow 2026-01-05 23:40:31 -05:00
parent aaad50c10d
commit 4d0b75a1c5
4 changed files with 20 additions and 24 deletions

View file

@ -47,7 +47,7 @@ class _VideoState extends State<Video> with WidgetsBindingObserver {
params: AndroidWebViewWidgetCreationParams(
controller: widget.videoStore.videoWebViewController.platform,
displayWithHybridComposition:
!widget.videoStore.settingsStore.useEnhancedRendering,
!widget.videoStore.settingsStore.useTextureRendering,
),
);
} else {

View file

@ -64,7 +64,7 @@ abstract class _SettingsStoreBase with Store {
// Player defaults
static const defaultShowVideo = true;
static const defaultDefaultToHighestQuality = false;
static const defaultUseEnhancedRendering = true;
static const defaultUseTextureRendering = true;
// Overlay defaults
static const defaultShowOverlay = true;
@ -80,9 +80,9 @@ abstract class _SettingsStoreBase with Store {
@observable
var defaultToHighestQuality = defaultDefaultToHighestQuality;
@JsonKey(defaultValue: defaultUseEnhancedRendering)
@JsonKey(defaultValue: defaultUseTextureRendering)
@observable
var useEnhancedRendering = defaultUseEnhancedRendering;
var useTextureRendering = defaultUseTextureRendering;
// Overlay options
@JsonKey(defaultValue: defaultShowOverlay)
@ -101,7 +101,7 @@ abstract class _SettingsStoreBase with Store {
void resetVideoSettings() {
showVideo = defaultShowVideo;
defaultToHighestQuality = defaultDefaultToHighestQuality;
useEnhancedRendering = defaultUseEnhancedRendering;
useTextureRendering = defaultUseTextureRendering;
showOverlay = defaultShowOverlay;
toggleableOverlay = defaultToggleableOverlay;

View file

@ -22,7 +22,7 @@ SettingsStore _$SettingsStoreFromJson(
..launchUrlExternal = json['launchUrlExternal'] as bool? ?? false
..showVideo = json['showVideo'] as bool? ?? true
..defaultToHighestQuality = json['defaultToHighestQuality'] as bool? ?? false
..useEnhancedRendering = json['useEnhancedRendering'] as bool? ?? true
..useTextureRendering = json['useTextureRendering'] as bool? ?? true
..showOverlay = json['showOverlay'] as bool? ?? true
..toggleableOverlay = json['toggleableOverlay'] as bool? ?? false
..showLatency = json['showLatency'] as bool? ?? true
@ -99,7 +99,7 @@ Map<String, dynamic> _$SettingsStoreToJson(
'launchUrlExternal': instance.launchUrlExternal,
'showVideo': instance.showVideo,
'defaultToHighestQuality': instance.defaultToHighestQuality,
'useEnhancedRendering': instance.useEnhancedRendering,
'useTextureRendering': instance.useTextureRendering,
'showOverlay': instance.showOverlay,
'toggleableOverlay': instance.toggleableOverlay,
'showLatency': instance.showLatency,
@ -296,26 +296,22 @@ mixin _$SettingsStore on _SettingsStoreBase, Store {
);
}
late final _$useEnhancedRenderingAtom = Atom(
name: '_SettingsStoreBase.useEnhancedRendering',
late final _$useTextureRenderingAtom = Atom(
name: '_SettingsStoreBase.useTextureRendering',
context: context,
);
@override
bool get useEnhancedRendering {
_$useEnhancedRenderingAtom.reportRead();
return super.useEnhancedRendering;
bool get useTextureRendering {
_$useTextureRenderingAtom.reportRead();
return super.useTextureRendering;
}
@override
set useEnhancedRendering(bool value) {
_$useEnhancedRenderingAtom.reportWrite(
value,
super.useEnhancedRendering,
() {
super.useEnhancedRendering = value;
},
);
set useTextureRendering(bool value) {
_$useTextureRenderingAtom.reportWrite(value, super.useTextureRendering, () {
super.useTextureRendering = value;
});
}
late final _$showOverlayAtom = Atom(
@ -1121,7 +1117,7 @@ largeStreamCard: ${largeStreamCard},
launchUrlExternal: ${launchUrlExternal},
showVideo: ${showVideo},
defaultToHighestQuality: ${defaultToHighestQuality},
useEnhancedRendering: ${useEnhancedRendering},
useTextureRendering: ${useTextureRendering},
showOverlay: ${showOverlay},
toggleableOverlay: ${toggleableOverlay},
showLatency: ${showLatency},

View file

@ -33,13 +33,13 @@ class VideoSettings extends StatelessWidget {
),
if (Platform.isAndroid)
SettingsListSwitch(
title: 'Use enhanced rendering',
title: 'Use fast video rendering',
subtitle: const Text(
'Uses a faster WebView rendering method. Disable if you experience crashes while watching streams.',
),
value: settingsStore.useEnhancedRendering,
value: settingsStore.useTextureRendering,
onChanged: (newValue) =>
settingsStore.useEnhancedRendering = newValue,
settingsStore.useTextureRendering = newValue,
),
const SectionHeader('Overlay'),
SettingsListSwitch(