From 43d55c785b6ff35a297de7b1ae574a7583fdf2b7 Mon Sep 17 00:00:00 2001 From: Tommy Chow Date: Sun, 31 Jul 2022 20:51:27 -0400 Subject: [PATCH] Fix PiP not dismissing on iOS (#168) Reload webview when dispoing video --- lib/screens/channel/stores/video_store.dart | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/screens/channel/stores/video_store.dart b/lib/screens/channel/stores/video_store.dart index fbaa74cd..915827c1 100644 --- a/lib/screens/channel/stores/video_store.dart +++ b/lib/screens/channel/stores/video_store.dart @@ -285,7 +285,10 @@ abstract class VideoStoreBase with Store { @action void dispose() { - controller?.runJavascript('document.getElementsByTagName("video")[0].pause();'); + // Not ideal, but seems like the only way of disposing of the video properly. + // Will both prevent the video from continuing to play when dismissed and closes PiP on iOS. + controller?.reload(); + _disposeOverlayReaction(); floating.dispose(); sleepTimer?.cancel();