From 7df42c6ca449e20fb0ccb3ebccf6a1806075430b Mon Sep 17 00:00:00 2001 From: Robert Junkins <67753581+JustBobinAround@users.noreply.github.com> Date: Sun, 18 Dec 2022 16:37:23 -0500 Subject: [PATCH 1/2] numpy requirement changed to numpy==1.23.0 When building with the latest numpy version (v1.24.0), OpenSeeFace crashes with "AttributeError: module 'numpy' has no attribute 'float'". This is because the attribute 'float' is now deprecated in numpy v1.24. I have changed the requirements to the earlier version v1.23.0. This should probably only be a temporary fix, as I'm sure there is a good reason that float was depreciated. I would also recommend changing the requirements to a single file with a static version for each requirement that is known to work. This will help ensure the stability of the program. I may do this in another fork when I have more time if you want. --- make_exe.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/make_exe.bat b/make_exe.bat index a7b6ef8..762442b 100644 --- a/make_exe.bat +++ b/make_exe.bat @@ -11,7 +11,7 @@ call venv\Scripts\activate.bat echo "Installing dependencies" pip install wheel -pip install onnxruntime opencv-python==4.5.4.60 pillow numpy pyinstaller +pip install onnxruntime opencv-python==4.5.4.60 pillow numpy==1.23.0 pyinstaller echo "Running pyinstaller" pyinstaller facetracker.py --clean ^ From 624141fa6a5d048523ce8049b0e5c8433f5bc382 Mon Sep 17 00:00:00 2001 From: Robert Junkins <67753581+JustBobinAround@users.noreply.github.com> Date: Sun, 18 Dec 2022 16:39:41 -0500 Subject: [PATCH 2/2] numpy requirement changed to numpy==1.23.0 When building with the latest numpy version (v1.24.0), OpenSeeFace crashes with "AttributeError: module 'numpy' has no attribute 'float'". This is because the attribute 'float' is now deprecated in numpy v1.24. I have changed the requirements to the earlier version v1.23.0. This should probably only be a temporary fix, as I'm sure there is a good reason that float was depreciated. I would also recommend changing the requirements to a single file with a static version for each requirement that is known to work. This will help ensure the stability of the program. I may do this in another fork when I have more time if you want. --- make_exe.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/make_exe.sh b/make_exe.sh index 834d486..1963f23 100755 --- a/make_exe.sh +++ b/make_exe.sh @@ -21,7 +21,7 @@ source venv/bin/activate echo "Installing packages" pip install wheel # Make sure this is installed beforehand -pip install onnxruntime opencv-python==4.5.4.60 pillow numpy pyinstaller +pip install onnxruntime opencv-python==4.5.4.60 pillow numpy==1.23.0 pyinstaller echo "Creating binary" pyinstaller --onedir --clean facetracker.py \